Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Chinese (Cantonese) voice is broken #10418

Closed
kara-louise opened this issue Oct 24, 2019 · 10 comments · Fixed by #12370
Closed

The Chinese (Cantonese) voice is broken #10418

kara-louise opened this issue Oct 24, 2019 · 10 comments · Fixed by #12370
Labels
component/speech feature/i18n Internationalization features
Milestone

Comments

@kara-louise
Copy link

As the title says, this voice is broken.
After a quick look at eSpeak NG's source files, there are a few that start with zhy. I believe these, when compiled, create the Cantonese voice. I couldn't find any zhy files in C:\Program Files (x86)\NVDA\synthDrivers\espeak-ng-data.

Steps to reproduce:

  1. Open NVDA's speech settings page.
  2. In the voice combo box, select "Chinese (Cantonese")

Actual behavior:

NVDA doesn't speak.

Expected behavior:

NVDA should speak with the selected voice.

System configuration

NVDA installed/portable/running from source:

Installed, but this also happens with portable installations.

NVDA version:

2019.2.1

Windows version:

10.0.18362 Build 18362

Name and version of other software in use when reproducing the issue:

Other information about your system:

Other questions

Does the issue still occur after restarting your PC?

Yes.

Have you tried any other versions of NVDA? If so, please report their behaviors.

latest snapshot build (alpha-19004,ab429417) at time of writing.
Same issue occurs.

@Brian1Gaff
Copy link

Brian1Gaff commented Oct 24, 2019 via email

@kara-louise
Copy link
Author

eSpeak NG isn't currently SAPI 5 compatible. But I installed the latest stable windows build ( 1.49.2 3ed34d3 released on Sep 24, 2017), and it does include a "zhy_dict" file.
If placed in synthDrivers\espeak-ng-data,, I get speech when selecting the Cantonese voice, but Chinese characters are read as "Chinese letter x" Where x is a number.
I lack the skills to build eSpeak NG from source so can't check the master branch as it stands currently.
So the build included with NVDA's missing a file.

@LeonarddeR
Copy link
Collaborator

I can not reproduce this issue.

@feerrenrut May be we should consider a bump of espeak?

@zstanecic
Copy link
Contributor

zstanecic commented Oct 29, 2019 via email

@feerrenrut
Copy link
Contributor

zhy dictionary compilation is intentionally excluded.
If someone wishes to investigate further, see nvdaHelper/espeak/sconscript
Under the comment #Compile all dictionaries
Change the line:
missingDicts=['zhy', ] #'mt','tn','tt']
to:
missingDicts = []
And try to build, the errors are:

espeak_compileDict_buildAction(["include\espeak\espeak-ng-data\zhy_dict"], ["include\espeak\dictsource\zhy_rules"])
espeak_compileDict_action: failed to switch to language b'zhy'
scons: *** [include\espeak\espeak-ng-data\zhy_dict] Error 1

@Qchristensen
Copy link
Member

I've had correspondence from another user reporting this. Did we work out what the issue is with the language?

@kara-louise
Copy link
Author

The voice's still broken in alpha-20758,0098a31a.

@feerrenrut
Copy link
Contributor

I have a potential fix for this, could you please test this build from #12370

@kara-louise
Copy link
Author

@feerrenrut That seems to work.

@feerrenrut feerrenrut added this to the 2021.1 milestone May 28, 2021
@feerrenrut
Copy link
Contributor

Fixed via fca3c2d in PR Fix compilation of espeak dictionary for language zhy #12370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/speech feature/i18n Internationalization features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants