Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the Input gesture manager allowing to open many instances of them #12673

Closed
CyrilleB79 opened this issue Jul 22, 2021 · 4 comments · Fixed by #12693
Closed

Error in the Input gesture manager allowing to open many instances of them #12673

CyrilleB79 opened this issue Jul 22, 2021 · 4 comments · Fixed by #12693
Assignees
Milestone

Comments

@CyrilleB79
Copy link
Collaborator

Steps to reproduce:

  • Open the Input gesture manager
  • Shift-tab back in the filter field
  • Type a string with a typo leading to no result in the tree, e.g. "zzzz"
  • Press Escape to close the dialog
  • Open the input gesture manager dialog
  • Open again the input gesture manager dialog, without closing the previous instance.

Actual behavior:

  • First errors in the log appear as soon as you type "zzzz"
  • Two or more instances of the input gesture manager are opened

Expected behavior:

  • No error in the log
  • There should not be a way to open two instances of the input gesture manager and the usual message should appear.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2021.1

Windows version:

Windows 10 2004 (64-bit) build 19041.388

Name and version of other software in use when reproducing the issue:

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

2020.4 does not have this issue.

If add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Not tested

Maybe a regression with wxPython upgrade?
Cc @seanbudd

@feerrenrut
Copy link
Contributor

@CyrilleB79 Could you attach a log snippet for the error please?

@seanbudd seanbudd added this to the 2021.2 milestone Jul 23, 2021
@CyrilleB79
Copy link
Collaborator Author

Yes. Sorry. I had prepared the log but have forgotten to attach it to this issue.
I'll attach it when I am back on my home's computer tonight.

@CyrilleB79
Copy link
Collaborator Author

Here is the log:
nvda.log

The first error is line 403.

@feerrenrut
Copy link
Contributor

Thanks @CyrilleB79
Here is the error / stack for convenience:

DEBUG - gui.inputGestures._GesturesTree.getData (23:10:05.261) - MainThread (18736):
Getting data for item indexes (0, None, None)
ERROR - gui.inputGestures._GesturesTree.getData (23:10:05.264) - MainThread (18736):
Exceeded expected categories bounds, trying to access category with index 0, but only 0 exist.
Stack trace:
  File "nvda.pyw", line 359, in <module>
  File "core.pyc", line 750, in main
  File "wx\core.pyc", line 2237, in MainLoop
  File "gui\inputGestures.pyc", line 626, in onFilterChange
  File "gui\inputGestures.pyc", line 634, in filter
  File "gui\inputGestures.pyc", line 541, in doRefresh
  File "wx\lib\mixins\treemixin.pyc", line 371, in RefreshItems
  File "wx\lib\mixins\treemixin.pyc", line 397, in RefreshChildrenRecursively
  File "gui\inputGestures.pyc", line 639, in onTreeSelect
  File "gui\inputGestures.pyc", line 642, in _refreshButtonState
  File "gui\inputGestures.pyc", line 489, in getSelectedItemData
  File "gui\inputGestures.pyc", line 505, in getData
ERROR - unhandled exception (23:10:05.265) - MainThread (18736):
Traceback (most recent call last):
  File "gui\inputGestures.pyc", line 639, in onTreeSelect
  File "gui\inputGestures.pyc", line 642, in _refreshButtonState
  File "gui\inputGestures.pyc", line 489, in getSelectedItemData
  File "gui\inputGestures.pyc", line 499, in getData
IndexError: list index out of range

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants