Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider splitting braille.py into smaller files. #12772

Open
TheQuinbox opened this issue Aug 24, 2021 · 4 comments
Open

Consider splitting braille.py into smaller files. #12772

TheQuinbox opened this issue Aug 24, 2021 · 4 comments
Labels
audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.

Comments

@TheQuinbox
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The brialle module (source/braille.py) is quite large (over 100 KB). This makes navigating it hard.

Describe the solution you'd like

Something similar to what we did with controlTypes, split braille into smaller modules, hopefully not breaking addons in the process.

Describe alternatives you've considered

None

Additional context

None
@josephsl
Copy link
Collaborator

josephsl commented Aug 24, 2021 via email

@feerrenrut
Copy link
Contributor

We might consider this for 2022.1

@feerrenrut feerrenrut added this to the 2022.1 milestone Aug 25, 2021
@TheQuinbox
Copy link
Contributor Author

Fair enough. Figured that, but thought I'd open the issue now.

@feerrenrut feerrenrut removed this from the 2022.1 milestone Feb 14, 2022
@ehollig ehollig added the audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers label Sep 22, 2022
@seanbudd seanbudd added p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Oct 25, 2022
@burmancomp
Copy link
Contributor

cc: @Emil-18

This would be useful. Maybe also more such things as docstrings and comments for simple men like me.

@seanbudd seanbudd mentioned this issue Apr 19, 2024
Closed
5 tasks
@LeonarddeR LeonarddeR mentioned this issue May 27, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@feerrenrut @seanbudd @josephsl @ehollig @TheQuinbox @burmancomp