stop HID Braille routing keys from being back to front #12860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r, as Windows provides it backwards. This fix ensures that routing keys work correctly. They were previously reversed. Also there is no need to add 1 to the routing index, NVDA's routing key routing indexes start at 0, not 1.
seanbudd
approved these changes
Sep 20, 2021
|
Should this PR have a changelog entry, since the HID driver is new to 2021.3? |
|
I've now removed that line in beta commit b7fd077.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes routing key bug mentioned by @FelixGruetzmacher in pr #12523
Summary of the issue:
When testing with multiple HID braille displays, it has been found that NVDA's handling of routing keys seems to be reversed, and also offset by 1.
the offset by 1 issue is just an incorrect assumption by me -- NVDA's routing key routing indexes start at 0, not 1.
However, the reverse order of the keys is due to the fact that Windows apparently loads its HID input button caps arrays in reverse order. This fact is mentioned in the Microsoft Docs article at https://docs.microsoft.com/en-us/windows-hardware/drivers/hid/button-capability-arrays
Description of how this pull request fixes the issue:
In the HID braille driver:
Testing strategy:
On an Orbit Reader 40 set to HID Braille mode: pressed various routing keys to ensure the cursor moved to the cell directly under that routing key.
Known issues with pull request:
None known.
Change log entries:
Bug fixes
Code Review Checklist: