Visual problems with Elements List #1321

Closed
nvaccessAuto opened this Issue Jan 16, 2011 · 6 comments

1 participant

@nvaccessAuto

Reported by msuch on 2011-01-16 09:14
The problem described here does not affect blind users of NVDA.
When activating the linklist on a page containing a great number of links, the window containing the linklist is visually messed up.
The list itself hides the "Filter with", "Move to" and "Cancel buttons", and you can't see all text in the list itself because it is hidden by two vertical scrollers.

The fix proposed here applies to file virtualBuffers__init__.py and
does the following:

  • Fixes the listbox size to 500, 300 to have all the text always displayed and not hiding the buttons;
  • the "filter by" edit field has been moved above the listobx, which seems more logical since the content of this edit field conditions the content of the listbox; the "Cancel" button has been separated a bit from other buttons;
  • Finally the whole window has been moved a bit up left.

the code is based on latest trunk source code R4014 so could be used as is.
See attached file for source code.

@nvaccessAuto

Attachment init.py added by msuch on 2011-01-16 09:16
Description:
File virtualBuffers__init__.py

@nvaccessAuto

Comment 1 by jteh on 2011-01-17 00:13
Thanks for your work. It'd be great if you could please submit code as patches in future. :)
Changes:
Changed title from "A fix for linklist getting visually messed up when used on a page containing a great number of links" to "Visual problems with Elements List"
Milestone changed from None to near-term

@nvaccessAuto

Comment 2 by jteh (in reply to comment description) on 2011-01-18 05:42
Replying to msuch:

  • Fixes the listbox size to 500, 300 to have all the text always displayed and not hiding the buttons;

Urg. Wx really should size the list properly without absolute sizing, but nothing I've tried works either, so this is the only solution.

  • the "filter by" edit field has been moved above the listobx, which seems more logical since the content of this edit field conditions the content of the listbox;

I understand your reasoning. However, the "Filter by" field is of less importance than the list itself for most users. If we move it before the list, the user will have to move two controls to get to the list from the radio buttons instead of just one.

  • Finally the whole window has been moved a bit up left.

Why this change?

@nvaccessAuto

Comment 3 by msuch (in reply to comment 2) on 2011-01-18 08:21
Replying to jteh:

Replying to msuch:

  • Fixes the listbox size to 500, 300 to have all the text always displayed and not hiding the buttons;

Urg. Wx really should size the list properly without absolute sizing, but nothing I've tried works either, so this is the only solution.

  • the "filter by" edit field has been moved above the listobx, which seems more logical since the content of this edit field conditions the content of the listbox;

I understand your reasoning. However, the "Filter by" field is of less importance than the list itself for most users. If we move it before the list, the user will have to move two controls to get to the list from the radio buttons instead of just one.

Ok, I also understand your point of view and have no real preference.

  • Finally the whole window has been moved a bit up left.

Why this change?

This one is only cosmetic, I've been told it was a bit nicest this way. In fact the only important thing in all this is the listbox sizing.

@nvaccessAuto

Comment 4 by mdcurran on 2011-01-31 01:16
Possibly fixed in 68efe91. Now we use proportional sizing, making the tree 7 10ths of the dialog, and the radio group, filter edit and buttons all 1 7th each. As far as I can tell with display model, everything is now on the screen, no matter how many elements appear in the tree. If the content can in deed bee seen now, please close as fixed.
Changes:
State: closed

@nvaccessAuto

Comment 5 by jteh on 2011-01-31 06:48
Changes:
Milestone changed from near-term to 2011.1

@nvaccessAuto nvaccessAuto added this to the 2011.1 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment