Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synthDriverHandler.synthChanged extension point #14618

Merged
merged 7 commits into from Feb 16, 2023

Conversation

LeonarddeR
Copy link
Collaborator

@LeonarddeR LeonarddeR commented Feb 9, 2023

Link to issue number:

Part of #14520

Description of development approach

added synthDriverHandler.synthChanged extension point, which behaves similar to braille.displayChanged. It includes an extension point.

Testing strategy:

Unit tests and manual testing using the python console.

Known issues with pull request:

None

Change log entries:

For Developers
- Added extension point: synthDriverHandler.synthChanged

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@LeonarddeR LeonarddeR requested a review from a team as a code owner February 9, 2023 18:24
@AppVeyorBot
Copy link

See test results for failed build of commit d6c6b1f8e6

@seanbudd seanbudd merged commit 86e9366 into nvaccess:master Feb 16, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants