Add support of getting link destination of graphic links

[beqabeqa473]

Link to issue number:

Closes #14779

Summary of the issue:

destination of graphic links are not reported in chrome/edge

Description of user facing changes

Destination of graphic links now should be reported in chrome/edge browsers

Description of development approach

NVDA lands its focus to graphic elemeng "img" which does not have href value, but an element which is parent of that element is link.
So one more check was introduced to ensure han if we are focusing a graphic element and its parent is a link, we are now replacing an object by its parent object

Testing strategy:

Opened a webpage with graphic links and ensured that their addresses are correctly reported

Known issues with pull request:

None

Change log entries:

New features
Changes
Bug fixes
Destination of graphic links are now corectly reported in chrome and edge browsers
For Developers

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.

[Adriani90]

Are image links also covered? See
https://www.rapidtables.com/web/html/link/html-image-link.html

[beqabeqa473]

That was a purpose of creating this pr

[Adriani90]

Ah ok sorry I thought there might be a difference between grafic links and image links, didn't mean to spam this. :-)

[seanbudd]

Thanks @beqabeqa473 - just a minor fix required in regards to comments

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• FAIL: Lint check. See test results for more information.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/tislop249qrrl0q8/artifacts/output/nvda_snapshot_pr14783-28033,fbca6802.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.9,
  INSTALL_END 1.1,
  BUILD_START 0.0,
  BUILD_END 27.1,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.4,
  TEST_START 0.0,
  TEST_END 23.0,
  FINISH_END 0.1

See test results for failed build of commit fbca680220

[amirsol81]

@beqabeqa473 @seanbudd I have Alpha 28043 for this graphic link-oriented fix, but it introduces one more serious issue.

1. Go to https://www.gsmarena.com/
2. Look for graphic links - many of them are there.
3. Having located either of them, press the Down arrow once to move to its following heading which also contains the link in non-graphic form. For instance, the graphic link might be "Xiaomi Redmi Note 12 4G review." Press the Down arrow once to move to the heading which says: "link heading level 3 Xiaomi Redmi Note 12 Pro review."
4. Press NVDA+K.
   NVDA incorrectly says: "Not a link." These are absolutely valid links which are now being ignored. This is with Chrome 112.

[beqabeqa473]

It is not related for this pr and linked issue.
I still have earlier alpha on my machine and can reproduce bug you are talking

[amirsol81]

You are right. I tested it with previous alphas and issue is duplicable. It seems that NVDA can’t get or report the destination of links which are embedded in headings - a serious issue IMO.

On Thu, Apr 6, 2023 at 08:07 Beqa Gozalishvili ***@***.***> wrote: It is not related for this pr and linked issue. I still have earlier alpha on my machine and can reproduce bug you are talking — Reply to this email directly, view it on GitHub <#14783 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIGLZMXZ3G35RK5FGCNH2YDW7ZCBPANCNFSM6AAAAAAWSHWFCA> . You are receiving this because you commented.Message ID: ***@***.***>

-- Sent from Gmail Mobile via iPhone