New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handy tech driver updates #14917
Merged
seanbudd
merged 9 commits into
nvaccess:master
from
FelixGruetzmacher:handy_tech_driver_updates
Jun 1, 2023
Merged
Handy tech driver updates #14917
seanbudd
merged 9 commits into
nvaccess:master
from
FelixGruetzmacher:handy_tech_driver_updates
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@FelixGruetzmacher A couple of asides if I may:
|
codeofdusk
reviewed
May 11, 2023
seanbudd
reviewed
Jun 1, 2023
seanbudd
reviewed
Jun 1, 2023
…ut arguments as it is now the recommended idiom in Python. Co-authored-by: Sean Budd <seanbudd123@gmail.com>
…e hint. Co-authored-by: Sean Budd <seanbudd123@gmail.com>
See test results for failed build of commit b54f0095d2 |
seanbudd
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FelixGruetzmacher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the issue:
Help Tech Activator Braille display was not supported.
Description of user facing changes
Activator is now detected and can be used.
Description of development approach
Modified driver and detection logic.
Testing strategy:
Tested Braille with updated driver in developer scratchpad.
Change log entries:
Help Tech Activator now supported.