Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aria-sort #1500

Closed
nvaccessAuto opened this Issue May 10, 2011 · 5 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto
Copy link

nvaccessAuto commented May 10, 2011

Reported by jteh on 2011-05-10 22:31
aria-sort "indicates if items in a table or grid are sorted in ascending or descending order" and is specified on table/grid headers. NVDA needs to support this concept in NVDAObjects and then report this via speech and braille.

This also needs to be supported for virtual buffers, but this will be done separately.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented May 16, 2011

Comment 2 by mdcurran on 2011-05-16 04:57
Announcement of aria-sort for MSHTML and Gecko virtualBuffers and NVDAObjects has been implemented in 5d31a28. However, this is only announcement on query/focus/caret/review etc, it does not announce when it changes. We need Gecko to fire iaatributeChange when sort changes, and for MSHTML, we probably need to register a propchange event at least for the focus, though what to actually call I'm not sure, probably just event_stateChange.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented May 17, 2011

Comment 3 by jteh on 2011-05-17 03:26
MozillaBug:640707 requests attributeChange for aria-sort.
Changes:
Changed title from "Support aria-sort in NVDAObjects" to "Support aria-sort"

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented May 19, 2011

Comment 4 by jteh on 2011-05-19 08:49
MozillaBug:640707 has been implemented and is available in Firefox 6 nightlies.

I committed a fix for announcing of "not sorted" in 9ead9cf.

I also committed a fix so that the gecko_ia2 buffer will correctly pick up aria-sort in 5a6cc55.

Finally, 763a1a1 makes speech.getControlFieldSpeech() announce states for table cells so that sorting is actually announced in virtual buffers.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented May 20, 2011

Comment 5 by jteh on 2011-05-20 03:02
Hopefully the correct state reporting code in 22af92d. :)

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented May 31, 2011

Comment 6 by jteh on 2011-05-31 06:15
Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.