Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more gestures for Albatross #15002

Merged
merged 4 commits into from Jun 14, 2023

Conversation

burmancomp
Copy link
Contributor

Link to issue number:

none

Summary of the issue:

Added some gestures.

Description of user facing changes

Added following gestures:

  • | Cycle the braille show messages mode | f1+f2, f9+f10 |
  • | Cycle the braille show selection state | f1+f5, f9+f14 |

Description of development approach

none

Testing strategy:

Tested with 80 cells model.

Known issues with pull request:

none known

Change log entries:

New features
Changes
Added gestures for cycling the braille show messages mode, and the braille show selection state.
Bug fixes
For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@AppVeyorBot
Copy link

See test results for failed build of commit 5edd965da0

@burmancomp burmancomp marked this pull request as ready for review June 13, 2023 16:09
@burmancomp burmancomp requested review from a team as code owners June 13, 2023 16:09
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @burmancomp

Copy link
Member

@Qchristensen Qchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs changes read well, thanks!

@seanbudd seanbudd merged commit f2cc0e2 into nvaccess:master Jun 14, 2023
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jun 14, 2023
@burmancomp burmancomp deleted the moreGesturesForAlbatross branch June 14, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants