Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Albatross: gesture for move system caret when routing review cursor #15122

Conversation

burmancomp
Copy link
Contributor

Link to issue number:

none

Summary of the issue:

Gesture for move system caret when routing review cursor

Description of user facing changes

| Cycle the braille move system caret when routing review cursor states | f1+f3, f9+f11 |

Description of development approach

Testing strategy:

Tested with 80 model.

Known issues with pull request:

none

Change log entries:

New features
Changes
Gesture for move system caret when routing review cursor
Bug fixes
For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@Brian1Gaff

This comment was marked as off-topic.

Copy link
Member

@Qchristensen Qchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the User Guide change:
Cycle the braille move system caret when routing review cursor states
should have quotes around the option:
Cycle the "braille move system caret when routing review cursor" states

(This would mean the other pre-existing option lines should be updated, but this one particularly looked out of place as one statement otherwise).

@XLTechie
Copy link
Contributor

XLTechie commented Jul 12, 2023 via email

@AppVeyorBot
Copy link

See test results for failed build of commit 467cda2640

@seanbudd seanbudd merged commit 239668a into nvaccess:master Jul 12, 2023
1 check was pending
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jul 12, 2023
@burmancomp burmancomp deleted the albatrossGestureForMoveCaretWhenRoutingReviewCursor branch July 12, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants