Add-on store: Handle bulk install

[seanbudd]

Link to issue number:

None

Summary of the issue:

To be able to stress test the add-on installation system, a method of bulk installing add-ons is useful.
There is also a general request from users to be able to perform bulk actions like installing, updating or removing add-ons.

Description of user facing changes

Users are now able to bulk install add-ons.
This can be done by selecting multiple add-ons in the available add-ons tab, then activating the context menu on the selection and choosing the install action.

Description of development approach

Create a separate context menu for bulk actions. This creates an API for future bulk actions.

Testing strategy:

Manually test STR in #15347

Test selecting multiple add-ons and performing bulk install

Known issues with pull request:

None

Change log entries:

New features

• The Add-on Store now supports installing add-ons in bulk by selecting multiple add-ons.

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/f9q5rjlgeuoqn9le/artifacts/output/nvda_snapshot_pr15350-29020,ac2866d2.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.8,
  INSTALL_END 0.8,
  BUILD_START 0.0,
  BUILD_END 23.9,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 22.0,
  FINISH_END 0.1

See test results for failed build of commit ac2866d2c4

[CyrilleB79]

@seanbudd, it's a very good news that you implement a way to perform actions on multiple add-ons.

Here are feedbacks from my first tests (commit e1a5f88):

1. When no add-on is selected in the list (control+space), calling context menu does nothing (as well as when the list is empty). Since you have added "No actions available for the selected add-ons" message when many add-ons are selected, it would be coherent to have a ui.message too in this case.
2. When 3 add-ons are selected, always the first add-on's description (and details) appears in the right panel. It would make sense to indicate "3 add-ons selected" and let the description and other details empty. Or maybe put the list of the add-ons in one of these two fields? (not fully convinced)
3. When more than one add-on are selected, the menu in the "Actions" button is still the one corresponding to the first selected add-on. It should be the same as the context menu in the list. If there is no action in the context menu, the button should be greyed out.
4. When you have installed many add-ons that are in pending install state, you still can access the context menu to install them again. You should have the context menu item allowing to install various add-ons only if at least one add-on in the selection can be installed, i.e. would have the "Install" item in its context menu if selected alone.
5. With commit e1a5f88, if I select and install all the add-ons of the add-on store and control+tab immediately, I still have a lot of errors in the log.
6. From the description, I can see that you will allow other actions on multipe add-ons. Will you do this in this PR or not? It would make sense to add uninstall and migrate in the current PR (or at least in the same release as this PR). In a second time,enable, disable and enable overriding compatibility would also be very useful (requested in In the add-on manager, allow to enable or disable multiple add-ons in one time #11317).

I can see that this PR is now in Draft again, so feel free to ignore my comment if they do not apply anymore.

[cary-rowen]

Hi @seanbudd

Here is an important question for Chinese users:

As we all know, in a list control that supports multiple selections, users can hold down the Ctrl key and then press the arrow keys to locate the item they wish to select. After finding the item, they can press the space key. This process is valuable for selecting multiple non-adjacent items.

However, there are certain differences in the Chinese version of Windows: the Ctrl+Space shortcut is utilized to globally switch input languages.

Consequently, Chinese users encounter a need for an alternative method when attempting to select multiple non-adjacent items in the list.

The solution provided by Microsoft is to maintain the Ctrl key pressed while searching for the desired item within the list. After locating the item, if the user wishes to select it, they need to momentarily release the Ctrl key and then press the space key to select the current item. If the user intends to continue selecting other items, they must keep the Ctrl key held down and repeat the aforementioned steps.

The existing issue is that the action button activates when I press the space key by itself. While I can select adjacent items by pressing Shift along with the arrow keys, I am unable to select non-adjacent items.

By the way, the interaction of pressing the space key to activate an action button when a list item is focused is somewhat perplexing, and I rarely encounter it.

Cheers
Cary

[CyrilleB79]

Hi @seanbudd

Here is an important question for Chinese users:

As we all know, in a list control that supports multiple selections, users can hold down the Ctrl key and then press the arrow keys to locate the item they wish to select. After finding the item, they can press the space key. This process is valuable for selecting multiple non-adjacent items.

However, there are certain differences in the Chinese version of Windows: the Ctrl+Space shortcut is utilized to globally switch input languages.

Consequently, Chinese users encounter a need for an alternative method when attempting to select multiple non-adjacent items in the list.

The solution provided by Microsoft is to maintain the Ctrl key pressed while searching for the desired item within the list. After locating the item, if the user wishes to select it, they need to momentarily release the Ctrl key and then press the space key to select the current item. If the user intends to continue selecting other items, they must keep the Ctrl key held down and repeat the aforementioned steps.

The existing issue is that the action button activates when I press the space key by itself. While I can select adjacent items by pressing Shift along with the arrow keys, I am unable to select non-adjacent items.

By the way, the interaction of pressing the space key to activate an action button when a list item is focused is somewhat perplexing, and I rarely encounter it.

Cheers Cary

Note that pressing space on an unselected item in a list (Windows Explorer) also selects it, even on non-Chinese Windows (tested on French). Thus @cary-rowen's suggestion to remove space shortcut key in the add-on list fully makes sense. Enter or Appplication key (or shift+F10) will still allow to open the context menu of an add-on.

@cary-rowen out of curiosity, how do you unselect an item when performing a multi-selection in list on a Chinese system? E.g. when you want to select all items (control+A) and unselect only one in the middle of them?

[cary-rowen]

Hi @CyrilleB79

Thanks for letting me know that this issue is also affecting French users.

@cary-rowen out of curiosity, how do you unselect an item when performing a multi-selection in list on a Chinese system? E.g. when you want to select all items (control+A) and unselect only one in the middle of them?

In this case my steps are as follows:

1. Press Ctrl+A;
2. Hold down the CTRL key and press the arrow keys to navigate to an item I don't want selected.
3. Press Ctrl+Alt+Space NVDA will report "Not selected".
4. However, in Windows Explorer, an easier way might be to use invert selection LOL but this doesn't seem to have a shortcut key.
   BTW, starting from Windows 10, the default shortcut key for Microsoft Pinyin input method interferes with the shortcut key I mentioned in step (3), because the shortcut key is also used to switch Chinese or English input.

Cheers
Cary

[CyrilleB79]

Hi @CyrilleB79

Thanks for letting me know that this issue is also affecting French users.

No, this issue does not affect French users. I just wanted to say that the way Chinese people perform selection in list is not a specificity of Chinese systems and is doable on other systems.

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/vnmgfi6totq2w2ub/artifacts/output/nvda_snapshot_pr15350-29123,603f9a50.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.8,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  BUILD_END 24.8,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 19.7,
  FINISH_END 0.1

See test results for failed build of commit 603f9a50f8

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/p6gwbh7mtylh3s0u/artifacts/output/nvda_snapshot_pr15350-29139,a52ebe99.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.8,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  BUILD_END 24.7,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 22.2,
  FINISH_END 0.1

See test results for failed build of commit a52ebe9971

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• FAIL: Lint check. See test results for more information.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/cyyir1599iejo4jo/artifacts/output/nvda_snapshot_pr15350-29168,68bf9223.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.9,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  BUILD_END 25.8,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 23.4,
  FINISH_END 0.1

See test results for failed build of commit 68bf9223f2

[Qchristensen]

Looks good.