Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speech viewer no longer has a shortcut key in the tools menu in 2023.2 #15362

Closed
Qchristensen opened this issue Sep 4, 2023 · 3 comments · Fixed by #15364
Closed

Speech viewer no longer has a shortcut key in the tools menu in 2023.2 #15362

Qchristensen opened this issue Sep 4, 2023 · 3 comments · Fixed by #15364
Labels
p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@Qchristensen
Copy link
Member

Steps to reproduce:

With NVDA 2023.2 installed:

  • Press NVDA+n, then t to open the tools menu.
  • Arrow through the options and note the keys associated with each.
  • Press S (the key used to open this feature in 2023.1).

Actual behavior:

Speech viewer no longer has an associated key, and S now opens the add-on store ("A" opened the add-on manager in 2023.1).

Expected behavior:

There should be a shortcut key to toggle speech viewer.

It may be worth considering making "A" the key for add-on manager and leaving S for speech viewer (S still works in temporary copies so the shortcut hasn't been removed, it has just been overridden by the add-on store).

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

NVDA version:

2023.2 installed

Windows version:

Windows 11 (64-bit) Version: 22H2, Build: 22621.2134 (although this is likely irrelevant).

Name and version of other software in use when reproducing the issue:

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Have you tried any other versions of NVDA? If so, please report their behaviors.

If NVDA add-ons are disabled, is your problem still occurring?

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

@jcsteh
Copy link
Contributor

jcsteh commented Sep 4, 2023

My guess is that this was never defined with an access key (&S). When there was no other item with that access key, that was fine; Windows chose S as the first letter. Now that we do have something with that access key (Add-on store), that clobbered the (non-explicit) Speech viewer access key.

As a matter of interest, why did we choose s for Add-on store instead of a (as was previously the case before the store)?

@Brian1Gaff
Copy link

Brian1Gaff commented Sep 4, 2023 via email

@seanbudd
Copy link
Member

seanbudd commented Sep 4, 2023

As a matter of interest, why did we choose s for Add-on store instead of a (as was previously the case before the store)?

For a certain period of development, both the manager and the store was available. This was an artifact that got mistakenly retained.

I think we can reassign it to a and make the speech viewer key explicit as well

@seanbudd seanbudd modified the milestones: 2024.1, 2023.3 Sep 4, 2023
@seanbudd seanbudd added p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants