Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config migration seems to fail for excluded displays when trying to update from a previous alpha build #15370

Closed
LeonarddeR opened this issue Sep 5, 2023 · 1 comment
Labels
p1 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@LeonarddeR
Copy link
Collaborator

          The config migration seems to fail. When trying to update from a previous alpha build, I get:
Traceback (most recent call last):
  File "config\__init__.pyc", line 571, in _initBaseConf
  File "config\__init__.pyc", line 605, in _loadConfig
  File "config\__init__.pyc", line 601, in _loadConfig
  File "config\profileUpgrader.pyc", line 24, in upgrade
  File "config\profileUpgrader.pyc", line 41, in _doConfigUpgrade
  File "config\profileUpgradeSteps.pyc", line 368, in upgradeConfigFrom_10_to_11
  File "configobj\__init__.pyc", line 508, in __getitem__
KeyError: 'excludedDisplays'

Originally posted by @bramd in #15200 (comment)

@LeonarddeR LeonarddeR added p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Sep 5, 2023
@LeonarddeR LeonarddeR added this to the 2023.3 milestone Sep 5, 2023
@LeonarddeR LeonarddeR added p1 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority and removed p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority labels Sep 5, 2023
@LeonarddeR
Copy link
Collaborator Author

This can actually lead to a pretty severe crash:

core failure
Traceback (most recent call last):
  File "config\__init__.pyc", line 571, in _initBaseConf
  File "config\__init__.pyc", line 605, in _loadConfig
  File "config\__init__.pyc", line 601, in _loadConfig
  File "config\profileUpgrader.pyc", line 24, in upgrade
  File "config\profileUpgrader.pyc", line 41, in _doConfigUpgrade
  File "config\profileUpgradeSteps.pyc", line 368, in upgradeConfigFrom_10_to_11
  File "configobj\__init__.pyc", line 508, in __getitem__
KeyError: 'auto'

Now this is strange, because the key is really part of the config spec. It looks like the config spec isn't applied to the profile at migration time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

No branches or pull requests

1 participant