Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The incompatible add-ons dialog can lead users to believe that add-ons enabled by overriding compatibility will be disabled again. #15414

Closed
cary-rowen opened this issue Sep 10, 2023 · 5 comments
Labels
feature/addon-store Features / behavior of the add-on Store p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@cary-rowen
Copy link
Contributor

Steps to reproduce:

  1. Upgrade to NVDA-alpha-29119 (not the latest Alpha version), then override compatibility and enable some add-ons.
  2. Try upgrading from alpha-29119 to a newer version, such as alpha-29134.
  3. Before upgrading alpha-29134, you will see an incompatibility dialog. View incompatible add-ons in the dialog.

Actual behavior:

Those add-ons whose compatibility was overridden and enabled in step (1) will appear in the list.
This situation may lead users to believe that these add-ons will be disabled after installing alpha-29134.

Expected behavior:

Add-ons that are enabled by overriding compatibility should not appear in this list, as they will not be disabled after installing a new version of NVDA.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

Alpha Version

Windows version:

Windows 10 22H2 (AMD64) build 19045.3393

Name and version of other software in use when reproducing the issue:

None

Other information about your system:

None

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

n/a

If NVDA add-ons are disabled, is your problem still occurring?

Not tested

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

@CyrilleB79
Copy link
Collaborator

I think that it is expected that upgrading to a API-breaking release disable again add-ons that were previously enabled overriding compa issue. Is it what you are experimenting here?

Is it documented in the User Guide? If not, maybe it should be. Probably it should be in the change log at least.

Maybe it should also be documented in the UI in the same dialog that informs that some add-ons will be incompatible.

Let's hear NV Access opinion on this.

@cary-rowen
Copy link
Contributor Author

Hi @CyrilleB79

According to my tests:
When upgrading from one API-breaking version to another API-breaking version, NVDA claims that add-ons enabled by overriding compatibility will be disabled, but in fact they are not, and those add-ons remain enabled.

@CyrilleB79
Copy link
Collaborator

@cary-rowen you write:

Expected behavior:
Add-ons that are enabled by overriding compatibility should not appear in this list, as they will not be disabled after installing a new version of NVDA.

I think that the expected behaviour should be instead:
Add-ons that are enabled by overriding compatibility should be disabled again since the choice to override incompatibility was done in consideration of the previous API.

Add-ons that are enabled by overriding compatibility should not appear in this list, as they will not be disabled after installing a new version of NVDA.

@LeonarddeR
Copy link
Collaborator

I think the expected behavior should depend on the source and target API version difference. If you update from one API breaking Alpha to the nextt Alha, the API version should still be equal and therefore no add-ons should be disabled. If you are upgrading from 2024.1 to 2025.1 and you have an add-on force enabled that has a max version of 2023.1, the add-on should be disabled again.

@seanbudd seanbudd added this to the 2023.3 milestone Sep 11, 2023
@cary-rowen
Copy link
Contributor Author

I agree with @LeonarddeR that users upgrading to the same breaking API version should not disable add-ons that have been enabled by overriding compatibility.

@seanbudd seanbudd added p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. feature/addon-store Features / behavior of the add-on Store labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/addon-store Features / behavior of the add-on Store p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

No branches or pull requests

4 participants