Revert "NVDAObject.presentationType: groupings with position information but no name and no description should still be treated as content I.e. announced in focus ancestry. (#14878)" #15638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s their name or description as being labeled.
seanbudd
added
the
conceptApproved
seanbudd
reviewed
Oct 16, 2023
| @@ -287,7 +288,6 @@ eSpeak-NG, LibLouis braille translator, and Unicode CLDR have been updated. | |||
| - Script for reporting the destination of a link now reports from the caret / focus position rather than the navigator object. (#14659) | |||
| - Portable copy creation no longer requires that a drive letter be entered as part of the absolute path. (#14680) | |||
| - If Windows is configured to display seconds in the system tray clock, using ``NVDA+f12`` to report the time now honors that setting. (#14742) | |||
| - NVDA will now report unlabeled groupings that have useful position information, such as in recent versions of Microsoft Office 365 menus. (#14878) | |||
There was a problem hiding this comment.
this is removing a line from the 2023.2 change log which should remain unchanged
There was a problem hiding this comment.
@michaelDCurran It seems this PR has been merged without taking this suggestion into account.
There was a problem hiding this comment.
Oh, totally missed this. thanks for calling this out.
seanbudd
reviewed
Oct 16, 2023
seanbudd
approved these changes
Oct 16, 2023
Co-authored-by: Sean Budd <sean@nvaccess.org>
|
Maybe some kind of unique sound might be an option? As a person still trying to learn Windows later versions, often I find Microsoft's approach is very verbose on lots of things, but although verbose little really useful info is conveyed.
Brian
…--
***@***.***
Sent via blueyonder.(Virgin media)
Please address personal E-mail to:-
***@***.***, putting 'Brian Gaff'
in the display name field.
|
michaelDCurran
added a commit
that referenced
this pull request
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bcc7f25.
Link to issue number:
Reverts pr #14878
Closes #15324
Summary of the issue:
Traditionally, NvDA has only ever announced groupings in the focus ancestry if they have a name or description.
Recently Microsoft had been placing unlabeled groupings within context menus in Office and other places, to denote visual spacing. Microsoft had also recently been exposing position info (x of y) on these groupings.
In order to take advantage of this new info, through suggestion from Microsoft, in pr #14878 NVDA started announcing these unalabeled groupings, if they had position info. the advantage being that the blind user would then have a much better idea of how these context menu items were grouped, and just how many were in each section.
However, it is very clear based on user feedback, that there are way too many small groupings for the extra speech to outway missing info. There are many groupings in these context menus with only 1 or 2 items, greatly slowing down a user's navigation.
Description of user facing changes
NVDA will again no longer report unlabeled gorupings in the focus ancestory.
Description of development approach
Reverts pr #14878.
this pr also tightens up the detection of labels for groupings and similar controls to ignore names and descriptions that only contain whitespace. This is necessary as in some builds of Office, Microsoft also started exposing a space character on the name of unlabeled groupings in order to force screen readers to announce the unlabeled groupings.
Testing strategy:
Moved up and down the context menu in Microsoft Word, ensuring that unlabeled groupings are no longer reported.
Tabbed through the windows settings app to ensure that labeled groupings are still announced.
Known issues with pull request:
Issue #15324 suggested a new setting for Object Presentation settings which would allow configuring if NVDA announced all groupings / labeled groupings / no groupings. But it primary motivation was to remove the announcement of unlabeled groupings. Thus, reverting pr #14878 seems a more straight forward solution for now. And later one we could consider re-introducing something optional - though I personally am not convinced there is much of a need. The community has been quite vocal about this.
remains a problem in the future, NVDA may also need to specifically filter out
Code Review Checklist: