Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find dialog improvement: allow to search by regexp #16426

Open
CyrilleB79 opened this issue Apr 18, 2024 · 14 comments
Open

Find dialog improvement: allow to search by regexp #16426

CyrilleB79 opened this issue Apr 18, 2024 · 14 comments
Labels
feature p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.

Comments

@CyrilleB79
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Text search is widely used by blind people, more widely than by sighted ones. That's why NVDA has a specific dialog to perform search in a browseable document.
Sometimes however, the text that needs to be found is not a specific word/string but rather a pattern, e.g. a number.

Describe the solution you'd like

I suggest to add an option in NVDA's find dialog to allow to search specifying a regex rather than a normal text string.

Considering this is a feature targeting advanced users, we may hide it, e.g.:

  • put it under a "more options" button in the find dialog
  • or displaying this option only if a "Use advanced find dialog" checkbox is checked in the Advanced settings dialog

Or we may leave this option accessible to all, considering that another regex option is already accessible in NVDA's dictionary dialogs.

Describe alternatives you've considered

Implement this in an add-on. See the following request:
marlon-sousa/EnhancedFindDialog#24

Additional context

None

@mltony

This comment was marked as duplicate.

@XLTechie
Copy link
Contributor

XLTechie commented Apr 21, 2024 via email

@ABuffEr

This comment was marked as duplicate.

@Adriani90

This comment was marked as resolved.

@seanbudd
Copy link
Member

seanbudd commented Apr 23, 2024

Reopening as this issue follows the issue template and more efficiently summaries #6916 - see this issue for more discussion/history
We generally encourage new issues to replace old issues without the template and hard to follow discussion

@Adriani90

This comment was marked as off-topic.

@seanbudd

This comment was marked as off-topic.

@Adriani90

This comment was marked as off-topic.

@gerald-hartig

This comment was marked as off-topic.

@Adriani90

This comment was marked as off-topic.

@XLTechie
Copy link
Contributor

IMO the most important concern from the old issue, is #6916 (comment), from @jcsteh.
Anyone considering working on this should be aware.

@XLTechie

This comment was marked as off-topic.

@Adriani90
Copy link
Collaborator

Adriani90 commented Apr 23, 2024 via email

@seanbudd

This comment was marked as off-topic.

@seanbudd seanbudd reopened this Apr 23, 2024
@seanbudd seanbudd added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority feature and removed p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

No branches or pull requests

7 participants