Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to analyze add-ons with VirusTotal from an action in the store #16434

Closed
nvdaes opened this issue Apr 21, 2024 · 6 comments
Closed

Comments

@nvdaes
Copy link
Sponsor Contributor

nvdaes commented Apr 21, 2024

Is your feature request related to a problem? Please describe.

Though security of add-ons cannot be warranted, analyzing them with VirusTotal at any moment, specially before installing, maybe very useful to see if bundled malware is detected, and,in this case, to request removal from the store.

Describe the solution you'd like

The URL of VirusTotal analysis for each submitted add-on would be shown in the details panel of the store,as well as making possible to open that URL from a new action.

Describe alternatives you've considered

Users can downloadthe add-on using the download URL,and then submit the file to Virus Total, and the download URL can also be submitted.

Additional context

nvaccess/addon-datastore#3246

@XLTechie
Copy link
Collaborator

XLTechie commented Apr 21, 2024 via email

@nvdaes
Copy link
Sponsor Contributor Author

nvdaes commented Apr 21, 2024

Luke wrote:

That is, if no add-on (after a while) makes it into the store without confirmation of VirusTotal, isn't the test result implied by the add-on being there? Wouldn't a simple "Scanned by virus total" notation be sufficient, with maybe more elaboration in the user guide?

I think it's betterto provide an action to scan the add-on whenever,since results maybe updated:
See the Real-time updates section of the following link:

https://docs.virustotal.com/docs/how-it-works

@Adriani90
Copy link
Collaborator

Can this not happen automatically in the background before downloading? Is there a way to do that maybe via an API or so?

@nvdaes
Copy link
Sponsor Contributor Author

nvdaes commented Apr 21, 2024

Adriani wrote:

Can this not happen automatically in the background before downloading? Is there a way to do that maybe via an API or so?

I think that, though this is possible in terms of programming, this may exceed available limits of the API, and perhaps this woldn't bring a benefit grater than cons.
See info about API and cuotas at:

https://docs.virustotal.com/docs/api-overview

@XLTechie
Copy link
Collaborator

XLTechie commented Apr 21, 2024 via email

@seanbudd
Copy link
Member

We won't be accepting add-ons with flagged issues with VirusTotal and plan to scan all add-ons currently uploaded.
False positives will require contacting the scanner engine, generally they have been responsive when fixing false positives with NVDA.
This is assuming the false positive rate isn't exceptionally high.

@seanbudd seanbudd closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants