Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to automatically Create a new folder and put all files there when creating a portable copy #16443

Open
Adriani90 opened this issue Apr 23, 2024 · 8 comments
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.

Comments

@Adriani90
Copy link
Collaborator

Adriani90 commented Apr 23, 2024

Is your feature request related to a problem? Please describe.

Summary of #3113. When creating a portable copy, over 100 files are being thrown in the location chosen in the portable installer. However, if a folder with many other files is chosen accidentally, the files are scattered all around and it is overly complicated to collect them and put them into a separate folder.

Describe the solution you'd like

Among the solutions proposed in #3113, most people agreed they wish to have NVDA creating a folder upon installing the portable copy.
Drawbacks pointed out by @jcsteh:

  • People might want to specify folder name by themselves
  • Adding a subfolder automatically might add confusions to the path when accessing it via the run dialog or when an external device should contain NVDA portable copy on the root.
  • Backwards compatibility from an UX perspective.

Mittigants:

  1. The label of the current edit field called "portable directory" could be renamed to "location for the portable copy"
  2. There could be a checkbox in the portable copy installer called "create a sub directory for the portable copy" located right next to the browse button
  3. When an user activates the checkbox, an additional edit field appears with the label "name of portable sub directory". This edit field could be automatically populated with "NVDA".
    This way, users could decide tehmselves if they want to throw all files in the "location for the portable directory", or if they prefer to activate the checkbox to create a sub directory with a specific name in that location.

Describe alternatives you've considered

As proposed by Jamie, A dialog warning the user that the location chosen contains already other files. However, this will be also shown when overriding an existing portable copy and could be confusing for users from an UX perspective.

Additional context

n/a

@Adriani90 Adriani90 changed the title automatically Create a new folder and put all files there when creating a portable copy Feature to automatically Create a new folder and put all files there when creating a portable copy Apr 23, 2024
@Adriani90
Copy link
Collaborator Author

@seanbudd if such summaries are prefered by NV Access, I can start working on things like this for old issues that contain very long discussions. I guess #3113 is quite well summarized here now.

@ABuffEr
Copy link
Contributor

ABuffEr commented Apr 23, 2024

  1. There could be a checkbox in the portable copy installer called "create a sub directory for the portable copy" located right next to the browse button
  2. When an user activates the checkbox, an additional edit field appears with the label "name of portable sub directory"

Sincerely, imho this risks to be further confusing for users, that probably avoid to change anything. Did you considered the @Qchristensen comment? It seems very reasonable...

@Adriani90
Copy link
Collaborator Author

@ABuffEr that comment I saw, but I thought populating the edit field with /nvda automatically will add the risk that the user forgets this and installs NVDA accidentally to a subdirectory without removing the /nvda.
That's why I thought adding the checkbox makes it more obvuious that a decision can be taken, and NVDA is still populated automatically in that new edit field.
If the user doesn't want to change anything, the checkbox can stay disabled by default.
But maybe I didn't fully understand that comment.

@wmhn1872265132
Copy link

wmhn1872265132 commented Apr 24, 2024

Another possible solution I thought of is to make the NVDA directory less complex by changing the folder structure of NVDA so that I don't have to add NVDA subfolders.

Implementation

  • Move files other than configuration files to a folder named with a version number (similar to the lib folder)
  • Create an NVDA.exe to start the NVDA.exe in the version folder

After doing this, only a few files/folders will exist in the NVDA root directory:

  • Version number folder (NVDA core file)
  • systemConfig/userConfig (NVDA configuration file)
  • NVDA.exe (NVDA launcher
  • Other required documents (if any)

Therefore, even if the user places the portable version where a large number of files exist, it will not be particularly troublesome to maintain.
Doing this will also solve:

  • Error in which files cannot be replaced when NVDA is updated
  • Possibility of seamless updates in the background

Known issues:

If the version folder cannot be deleted when updating NVDA, several version folders may be generated after multiple updates.

@Adriani90
Copy link
Collaborator Author

@wmhn1872265132 thanks for this proposal, I'd rather see it as a further optimization of the current situation, but it doesn't solve the root problem. Still people will have to grab those files manually, but ofcourse your proposal goes into the right direction as well. However, I don't know how the paths are defined in NVDA and which files are imported from the root directory, so the implementation might have some higher complexity.

@XLTechie
Copy link
Collaborator

XLTechie commented Apr 24, 2024 via email

@lukaszgo1
Copy link
Contributor

For me the current situation i.e. NVDA placing its files exactly in the specified folder is the ideal behavior. I understand that this is suitable only for power users, so its not a good default. To mitigate this concern I'd suggest to go the other way around i.e. create the folder by default, but ad a check box named "Create NVDA folder in the specified location" or similar. This check box should be checked by default and when unchecked the current behavior should be preserved.

@XLTechie
Copy link
Collaborator

XLTechie commented Apr 28, 2024 via email

@seanbudd seanbudd added p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

No branches or pull requests

6 participants