Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lao Grade 1 braille table #16470

Merged
merged 7 commits into from
May 10, 2024
Merged

Add Lao Grade 1 braille table #16470

merged 7 commits into from
May 10, 2024

Conversation

michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Apr 30, 2024

Link to issue number:

None.

Summary of the issue:

There have been requests for NVDA to support the Lao Grade 1 braille table. Liblouis does contain a braille table for Lao Grade1, but it is not listed for use in NVDA.

Description of user facing changes

the Lao Grade 1 braille table is now available in NVDA.

Description of development approach

Registered the Lao Grade 1 (lo-g1.utb) braille table with NvDA.

Testing strategy:

  • Verified that Lao Grade 1 shows up in the braille table selection list in NVDA settings.
  • Verified that Lao Grade 1 loads when chosen and Braille is written to the display.

Known issues with pull request:

None known.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@michaelDCurran michaelDCurran requested a review from a team as a code owner April 30, 2024 21:44
@michaelDCurran michaelDCurran requested review from seanbudd and removed request for a team April 30, 2024 21:44
@AppVeyorBot
Copy link

See test results for failed build of commit d80e1810a9

@@ -72,6 +72,7 @@ There are many minor bug fixes for applications, such as Thunderbird, Adobe Read
- Updated LibLouis Braille translator to [3.29.0 https://github.com/liblouis/liblouis/releases/tag/v3.29.0]. (#16259, @codeofdusk)
- Added new detailed (with capital letters indicated) Belarusian and Ukrainian Braille tables, along with a Spanish table for reading Greek texts.
-
- Added a braille table for Lao Grade 1. (#16470)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be added to the above sublist rather than it's own item?

seanbudd
seanbudd previously approved these changes Apr 30, 2024
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Apr 30, 2024
user_docs/en/changes.t2t Outdated Show resolved Hide resolved
seanbudd
seanbudd previously approved these changes May 1, 2024
@seanbudd seanbudd merged commit a8d843e into beta May 10, 2024
1 of 2 checks passed
@seanbudd seanbudd deleted the lao-g1 branch May 10, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. queued for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants