-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lao Grade 1 braille table #16470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See test results for failed build of commit d80e1810a9 |
seanbudd
reviewed
Apr 30, 2024
user_docs/en/changes.t2t
Outdated
@@ -72,6 +72,7 @@ There are many minor bug fixes for applications, such as Thunderbird, Adobe Read | |||
- Updated LibLouis Braille translator to [3.29.0 https://github.com/liblouis/liblouis/releases/tag/v3.29.0]. (#16259, @codeofdusk) | |||
- Added new detailed (with capital letters indicated) Belarusian and Ukrainian Braille tables, along with a Spanish table for reading Greek texts. | |||
- | |||
- Added a braille table for Lao Grade 1. (#16470) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be added to the above sublist rather than it's own item?
seanbudd
previously approved these changes
Apr 30, 2024
seanbudd
added
the
conceptApproved
Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
label
Apr 30, 2024
seanbudd
reviewed
May 1, 2024
seanbudd
previously approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conceptApproved
Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
queued for merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
There have been requests for NVDA to support the Lao Grade 1 braille table. Liblouis does contain a braille table for Lao Grade1, but it is not listed for use in NVDA.
Description of user facing changes
the Lao Grade 1 braille table is now available in NVDA.
Description of development approach
Registered the Lao Grade 1 (lo-g1.utb) braille table with NvDA.
Testing strategy:
Known issues with pull request:
None known.
Code Review Checklist: