Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Error when activating Notepad about box #1853

Closed
nvaccessAuto opened this Issue Oct 19, 2011 · 5 comments

Comments

Projects
None yet
2 participants

Reported by PZajda on 2011-10-19 23:12

  1. Open Notepad.
  2. Go to "?" then "About Notepad"
    Then there NVDA makes an error after some seconds.
    Log file attached.

Comment 1 by PZajda on 2011-10-19 23:22
Log file too big, downloadable on http://dl.dropbox.com/u/1185217/LogBugNotepad.txt

Comment 3 by Ahiiron on 2011-10-20 16:46
Confirmed as an issue in 2011.3b1 on XP. NVDA becomes very sluggish until dialog is closed.

Comment 4 by jteh on 2011-10-21 04:59
Confirmed. Does not happen in Windows 7. Happens with NVDA 2011.2, but not 2011.1.1.

Comment 5 by jteh on 2011-10-21 06:11
Regression caused by f370813.

It seems that there is a !SysLink control where !AccessibleChildren reports a child with child ID -4, but querying info for child ID -4 just throws errors. Therefore, it gets a role of unknown, so getDialogText tries to descend. Unfortunately, the children property on the IAccessible NVDAObject only aborts if the child ID is greater than 0, as opposed to not equal to 0, so we end up fetching children for the same object, thus the infinite recursion.

Mick, should we just change the children property to check for != 0 instead of > 0? Do you think this will break anything? Alternatively, should we be treating simple children with negative child IDs as invalid at a lower level?
Changes:
Milestone changed from None to 2011.3

Comment 6 by jteh on 2011-10-21 10:08
Fixed in 85fa331.
Changes:
State: closed

@nvaccessAuto nvaccessAuto added this to the 2011.3 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment