Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA should turn off virtual buffer on certain ARIA-enabled widgets #205

Closed
nvaccessAuto opened this issue Jan 1, 2010 · 6 comments
Closed
Assignees
Milestone

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Jan 1, 2010

Reported by vtsaran on 2008-10-24 22:20
NVDA should toggle virtual buffer off when an ENTER or a SPACE BAR is pressed on certain ARIA-enabled widgets such as tree view and tab pannel. Since complex widgets rely on their own keyboard navigation, using them in a virtual buffer will not be possible.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 1, 2010

Comment 2 by jteh on 2008-12-24 07:15
Partially fixed in r2615. It is not a complete fix because pressing enter on one of these controls which includes text in its descendants (e.g. paragraph within a tab) won't work. This is because pressing enter currently descends to the bottom of the object hierarchy to check for a node to activate, which will hit the paragraph instead of the tab. This needs to be modified to somehow check its ancestry for a control to activate.

Test cases:

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 1, 2010

Comment 3 by vtsaran on 2009-01-06 23:30
Using the latest daily snapshot, the tabs are not reported as tabs in a virtual buffer using examples above.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 1, 2010

Comment 4 by jteh (in reply to comment 3) on 2009-01-08 04:19
Replying to vtsaran:

Using the latest daily snapshot, the tabs are not reported as tabs in a virtual buffer using examples above.

This is a separate issue covered by #216.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 1, 2010

Comment 5 by jteh on 2009-01-12 05:16
As of r2649, NVDA will correctly switch to focus mode automatically if focused on an ARIA tab control.

Pressing enter on a tab while in browse mode still does not switch to focus mode, but it does activate the tab. We're uncertain whether switching to focus mode is actually correct behaviour in this case. The reason is that since all of the tabs are exposed in the buffer, the user probably just wants to activate the tab under the cursor, rather than switching to focus mode and then having to activate the correct tab anyway. If you really do want to interact with the tab, NVDA+space can be used. This is the same behaviour we use for buttons, checkboxes, etc. Vic, is this acceptable?

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 1, 2010

Comment 6 by vtsaran (in reply to comment 5) on 2009-01-14 07:12
Replying to jteh:

As of r2649, NVDA will correctly switch to focus mode automatically if focused on an ARIA tab control.

This works as advertised.

Pressing enter on a tab while in browse mode still does not switch to focus mode, but it does activate the tab. We're uncertain whether switching to focus mode is actually correct behaviour in this case. The reason is that since all of the tabs are exposed in the buffer, the user probably just wants to activate the tab under the cursor, rather than switching to focus mode and then having to activate the correct tab anyway. If you really do want to interact with the tab, NVDA+space can be used. This is the same behaviour we use for buttons, checkboxes, etc. Vic, is this acceptable?

Absolutely. I personally think this is a great resolution to the problem. As you point out, the user may not necessarily want to go into "focus mode" just to toggle the current tab. So totally agree with your approach.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 1, 2010

Comment 7 by jteh on 2009-01-14 07:15
Reporter is satisfied. That's good enough for me. :)
Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.