New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up arrow and down arrow keys should be reversed in Voice Settings dialog sliders #221

Closed
nvaccessAuto opened this Issue Jan 1, 2010 · 5 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto

nvaccessAuto commented Jan 1, 2010

Reported by jteh on 2008-11-05 23:44
IN the sliders for the speech parameters in the Voice Settings dialog, the up arrow key decreases the setting and down arrow increases it. This is not logical, as these are simple numeric settings, so up should increase and down should decrease. This also makes these sliders consistent with the synth settings ring.

The left and right arrow keys are fine as they are.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Attachment settingsDialogs.patch added by pvagner on 2009-07-16 19:02
Description:

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 1 by Bernd on 2009-07-16 10:31
It would be great to see this in release 0.6.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 2 by pvagner on 2009-07-16 12:29
I have just discovered there is a style wx.SL_INVERSE for wxpython sliders which changes the behaviour of up and down arrow keys. It however also changes value reporting. While going upwards the value is decreasing and while going down value is increasing.
Now we do need to decide whether we do want to implement our keys for classic slider or whether we do rather like inverse style and we'll need to override value reporting.
Changes:
Changed title from "Up arrow and downn arrow keys should be reversed in Voice Settings dialog sliders" to "Up arrow and down arrow keys should be reversed in Voice Settings dialog sliders"

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 22, 2010

Comment 4 by pvagner on 2010-09-22 04:49
After some reading I've found out wx does not fire appropriate events when changing the value of slider programmatically. I need to figure out how to post the event manually and then if you like we can use this patch.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 22, 2010

Comment 6 by pvagner on 2010-09-22 12:04
Implemented in fd1c265.
Changes:
Milestone changed from None to 2010.3
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment