the plus sign can't be used for key commands #2898

Closed
nvaccessAuto opened this Issue Dec 24, 2012 · 8 comments

1 participant

@nvaccessAuto

Reported by Bernd on 2012-12-24 12:01
I was unable to use the + sign in a gestures.ini. This key is at the ] sign on english keyboards.

@nvaccessAuto

Comment 1 by jteh on 2012-12-26 06:28
This occurs because + is used as a separator for multiple keys and is only handled for that purpose. We have two options:
1. Handle + specially if it occurs at the end of a gesture identifier; or
2. Have a special sequence of characters for +; e.g. the worde plus.
Thoughts (especially from Mick)?

@nvaccessAuto

Comment 2 by jteh on 2012-12-26 06:29
Changes:
Milestone changed from None to 2013.1

@nvaccessAuto

Comment 3 by ragb (in reply to comment 1) on 2012-12-26 11:59
Replying to jteh:

This occurs because + is used as a separator for multiple keys and is only handled for that purpose. We have two options:

  1. Handle + specially if it occurs at the end of a gesture identifier; or

  2. Have a special sequence of characters for +; e.g. the worde plus.

Thoughts (especially from Mick)?

Another suggestion would be to scape the plus sign, i.g. \+. That means backslash to be escaped too, as \\.

Personally I prefer alternative 1, using a special identifier such as "plus". Leaving a plus sign on the end does not provide any direct meaning to it, so unless you don't know what it does you can't really guess.

@nvaccessAuto

Comment 4 by jteh (in reply to comment 3) on 2012-12-26 12:51
Replying to ragb:

Another suggestion would be to scape the plus sign, i.g. \+. That means backslash to be escaped too, as \\.

I thought of this. However, this breaks existing gesture maps (even ones in code) which bind the \ key.

Personally I prefer alternative 1, using a special identifier such as "plus".

Actually, that was option 2. :)

@nvaccessAuto

Comment 5 by mdcurran on 2012-12-27 00:52
I agree with the word 'plus'. I assume its as simple as hard coding this in KeyboardInputGesture.getVKName?

@nvaccessAuto

Comment 6 by jteh on 2013-01-04 05:03
@Bernd, does NVDA actually say the correct key name in input help when you press the + (plus) key? On my system, it says = (equals), but that could be because I'm on an English system. That's a separate issue, but I wanted to make sure we don't need to address that one first.

@nvaccessAuto

Comment 7 by Bernd on 2013-01-04 09:53
yes, NVDA says the (plus) key correctly. Even in key commands like nvda++

@nvaccessAuto

Comment 8 by jteh on 2013-01-08 11:33
9a3c0f0
Changes:
State: closed

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015
@nvaccessAuto nvaccessAuto added this to the 2013.1 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment