Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

the change in checked status is ot announced with SPACEBAR in new rules wizard of Outlook. #3063

Closed
nvaccessAuto opened this Issue Mar 8, 2013 · 13 comments

Comments

Projects
None yet
1 participant

Reported by sumandogra on 2013-03-08 15:07
Outlook 2010
The change in checked status of the check boxes on using SPACEBAR in the new rule wizard is not announced by NVDA. One has to use NVDA KEY+TAB to find out the checked status. Alternatively one has to navigate away from that particular item and come back to find out the checked status change.
Steps to reproduce:

  1. In Outlook, go to home tab>rule>manage rules and alerts.
  2. Select new rule button in the rules and alerts dialog box.
  3. Follow the wizard to the step 2.
  4. A list of options is available in the form of check boxes list.
  5. Press SPACEBAR to select one of the options available.
  6. NVDA does not announce the change in the checked status.
  7. One has to use NVDA KEY+TAB to find out the change in the checked status every time to find out if the checked status has changed or not.

Comment 1 by sumandogra on 2013-03-09 11:28
by mistake same bug got submitted twice. its a duplicate of bug #3062, therefore marking it invalid.
Changes:
Added labels: invalid
State: closed

Comment 2 by jteh on 2013-03-09 11:50
Actually, I already deleted #3062. :)
Changes:
Removed labels: invalid
State: reopened

Attachment 3063.patch added by kyogesh on 2013-07-23 13:06
Description:
The patch for announcing the checkbox status.

Comment 3 by kyogesh on 2013-07-23 13:07
I have attached the patch for the fix please review it and let me know if any changes required.

Comment 4 by jteh on 2013-07-24 02:52
Thanks for the patch.

This change should be made so that the code only ever runs for that particular control, rather than in the base IAccessible NVDAObject. Otherwise, this check will run whenever space is pressed in any IAccessible object, which is a performance hit.

So, in the outlook app module, you'll need to create an NVDAObject overlay class for REListBox20W check boxes. See the Developer Guide for details on overlay classes.

Comment 5 by jteh on 2013-07-24 02:55
Two more points:

  • There's no need to call api.getFocusObject(), etc. The code is running because the object has focus, so you can just use self.
  • You should fake a state change event, rather than calling speech directly. That way, it'll work for braille as well. self.event_stateChange() should do nicely.

Attachment 3063_modified.patch added by kyogesh on 2013-07-24 07:42
Description:
I have made the changes you have asked for, please review this patch

Comment 6 by kyogesh on 2013-07-24 07:45
The problem with using self.event_stateChange() is that it only announces "checked" and "not checked" and not the checkbox display text.
If you think this should be the correct behavior then I'm okay with it.
Let me know if it still needs any further modifications.

Comment 7 by jteh on 2013-07-24 23:00
Perfect. Nice work.

Does the text of the control change when you toggle it? If not, speaking the state alone is fine; that's consistent with how we handle check boxes everywhere else.
Changes:
Milestone changed from None to next

Comment 8 by Michael Curran <mick@... on 2013-08-13 05:40
In [68af8b1]:

Announce the changed state of rule checkboxes in Outlook 2010 via script bound to space. Re #3063

Comment 9 by Michael Curran <mick@... on 2013-08-13 05:40
In [0430757]:

Merge branch 't3063' into next. Incubates #3063

Changes:
Added labels: incubating

Comment 10 by Michael Curran <mick@... on 2013-08-27 04:02
In [ecca387]:

Announce the changed state of rule checkboxes in Outlook 2010 via script bound to space. Fixes #3063

Changes:
Removed labels: incubating
State: closed

Comment 11 by jteh on 2013-11-26 23:26
Changes:
Milestone changed from next to 2013.3

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015

@nvaccessAuto nvaccessAuto added this to the 2013.3 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment