Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

IE: Useless window gets focus instead of Flash object #3364

Closed
nvaccessAuto opened this Issue Jul 15, 2013 · 7 comments

Comments

Projects
None yet
2 participants

Reported by jteh on 2013-07-15 05:16
Originally reported in ticket:3357#comment:5.

Str:

  1. Open a page containing a Flash object; e.g. http://federalstudentaid.ed.gov/mystory/
  2. Move to the Flash object and press enter.
  3. Try to cursor around the Flash content.
    Expected: You should be able ot cursor around the Flash content.
    Actual: A useless window object gets focus and you have to fiddle with focus to read the content.

Originally fixed in be88fc4 (#775), but broke in 2013.1, probably due to 0b1f669 (#2454).

Comment 2 by James Teh <jamie@... on 2013-07-15 05:29
In [4f33b24]:

In Internet Explorer, It is again not necessary to press tab to interact with an embedded object (such as Flash content) after pressing enter on it.

Previously, the code assumed that all objects that _might_ be Flash were definitely not MSHTML. However, after the change to support Flash in Windows 8 IE, this assumption is incorrect.
Re #3364.

Comment 3 by James Teh <jamie@... on 2013-07-15 05:29
In [28e4624]:

Merge branch 't3364' into next

Incubates #3364.

Changes:
Added labels: incubating

Comment 4 by jteh on 2013-07-15 05:32
Brian, this should fix the issue you had with http://kingston.talking-newspapers.co.uk/ where you had to switch away and back to read the content of the object. It'd be great if you can confirm this. The fix should be available in the 15 Jul next snapshot.

Comment 5 by briang1 on 2013-07-15 13:14
Well, only just downloaded the new version but yes it does seem better behaved now. It worked in 2013.1.1 some of the time though , so maybe that odd window was not always created. Who knows, this is probably why it was not spotted back then. Its worked on some sites, but some sites tended to use misbehaving flash in any case so it will be a while till I am happy!

As I say, Its much better now, so is probably back how it used to be.

Comment 7 by briang1 on 2013-07-16 07:05
OK since yesterday I've tested it with more sites and its far more predictable now, so I think its fixed.

Comment 8 by Michael Curran <mick@... on 2013-07-30 00:56
In [e6ec181]:

In Internet Explorer, It is again not necessary to press tab to interact with an embedded object (such as Flash content) after pressing enter on it.

Previously, the code assumed that all objects that _might_ be Flash were definitely not MSHTML. However, after the change to support Flash in Windows 8 IE, this assumption is incorrect.
Fixes #3364.

Changes:
Removed labels: incubating
State: closed

Comment 9 by jteh on 2013-11-26 23:16
Changes:
Milestone changed from next to 2013.2

@nvaccessAuto nvaccessAuto added this to the 2013.2 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment