New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word 2010 spell check - NVDA reports all bold text as incorrect #3431

Closed
nvaccessAuto opened this Issue Aug 10, 2013 · 14 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Aug 10, 2013

Reported by manish on 2013-08-10 07:12
In the spell check dialog in Word 2010, NVDA reports any bolded text in the context as the incorrect word instead of actually speaking the incorrect text. an example word document is attached.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Aug 10, 2013

Attachment NVDA speaks correct while incorrrec is not spoken.docx added by manish on 2013-08-10 07:16
Description:

-----------------------------7dd3523b1ce0fc4
Content-Disposition: form-data; name="replace"

on

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Aug 10, 2013

Comment 1 by manish on 2013-08-10 15:44
The fix was to use self.value instead of pulling out all the bolded text from the error context. I have created a branch with the fix at:
https://manish_agrawal@bitbucket.org/manish_agrawal/nvda.git

branch: t3431

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Aug 10, 2013

Comment 2 by jteh on 2013-08-10 22:36
Thanks for the code. Are you sure this works in all supported versions of Word (2003 and beyond)?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Aug 11, 2013

Comment 3 by manish (in reply to comment 2) on 2013-08-11 06:08
The change will only impact word version 13 or higher, so, office 2003 should not be affected. I haven't tested this with office 2007 though. i'll try to find a 2007 install to test this.
;
Replying to jteh:

Thanks for the code. Are you sure this works in all supported versions of Word (2003 and beyond)?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Aug 19, 2013

Comment 4 by manish (in reply to comment 3) on 2013-08-19 06:21
I tested this with office 2007 and office 2013.
This change only effects word version 13 and higher. Office 2007 is version 12 and is not affected by this change. The spell check window in office 2007does not expose the incorrect text as its value property and so, this fix is not applicable there anyway. 2003 and 2007 will continue to work the way they used to.
office 2013 has a different kind of spell check window and this change is irrelevant there.
So, this only effects word 2010 and works correctly there.

Replying to manish:

The change will only impact word version 13 or higher, so, office 2003 should not be affected. I haven't tested this with office 2007 though. i'll try to find a 2007 install to test this.

;

Replying to jteh:

Thanks for the code. Are you sure this works in all supported versions of Word (2003 and beyond)?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Oct 18, 2013

Comment 5 by manish on 2013-10-18 14:23
Created a new branch from master instead of the current one which was created from next:
in_t3431
https://manish_agrawal@bitbucket.org/manish_agrawal/nvda.git

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 1, 2014

Comment 7 by Michael Curran <mick@... on 2014-06-01 05:23
In [79de5c1]:

Merge branch 't3431' into next. Incubates #3431

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 1, 2014

Comment 8 by mdcurran (in reply to comment 5) on 2014-06-01 05:24
Replying to manish:
Thanks for the fix.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 1, 2014

Comment 9 by mdcurran on 2014-06-01 05:24
Changes:
Milestone changed from None to next

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 16, 2014

Comment 11 by Michael Curran <mick@... on 2014-06-16 01:02
In [326e652]:

Merge branch 't3431'. Fixes #3431

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 16, 2014

Comment 12 by mdcurran on 2014-06-16 01:23
Changes:
Milestone changed from next to 2014.3

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 30, 2014

Comment 13 by mdcurran on 2014-06-30 05:37
We have a regression caused by this ticket in master. When focusing on a Office 2010 spellcheck error field, only the text and error is spoken, rather than also the actual control itself.
This was introduced in aaf3a83
On line 69 of source/NVDAObjects/IAccessible/winword.py, the the lower speech.speakObjectProperties has been made conditional.
Manish: is there a reason for this code?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jul 1, 2014

Comment 14 by manish (in reply to comment 13) on 2014-07-01 03:03
I looked at the implementation and cannot recall why I put the "if" there. I should have put a comment there indicating the reason.
Will be more dilligent with comments going forward.

Also, in the current master, I get an error tabbing in and out of the error field in MS word 2010 spell checker. I am not sure if you are seeing that as well.

Replying to mdcurran:

We have a regression caused by this ticket in master. When focusing on a Office 2010 spellcheck error field, only the text and error is spoken, rather than also the actual control itself.

This was introduced in aaf3a83

On line 69 of source/NVDAObjects/IAccessible/winword.py, the the lower speech.speakObjectProperties has been made conditional.

Manish: is there a reason for this code?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jul 2, 2014

Comment 15 by mdcurran (in reply to comment 14) on 2014-07-02 02:42
Replying to manish:
No problem, It has been removed in the branch for #3833, and the tab issue has also been fixed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment