Can't switch to screen review if object has no location #3454

Closed
nvaccessAuto opened this Issue Aug 20, 2013 · 2 comments

1 participant

@nvaccessAuto

Reported by jteh on 2013-08-20 12:13
(Spun off ticket:1913#comment:10.)

If you're in object review and your navigator object is on an object with no location (obj.location is None), switching to screen review throws this error:

ERROR - scriptHandler.executeScript (22:09:53):
error executing script: <bound method GlobalCommands.script_reviewMode_next of <globalCommands.GlobalCommands object at 0x05631BB0>> with gesture u'NVDA+numpad 7'
Traceback (most recent call last):
  File "scriptHandler.py", line 165, in executeScript
    script(gesture)
  File "globalCommands.py", line 283, in script_reviewMode_next
    label=review.nextMode()
  File "review.py", line 133, in nextMode
    return label or nextMode(prev=prev,startMode=newMode)
  File "review.py", line 132, in nextMode
    label=setCurrentMode(newMode)
  File "review.py", line 113, in setCurrentMode
    pos=func(obj)
  File "review.py", line 62, in getScreenPosition
    pos=DisplayModelTextInfo(s,obj)
  File "displayModel.py", line 199, in __init__
    super(DisplayModelTextInfo, self).__init__(obj, position)
  File "textInfos\offsets.py", line 267, in __init__
    start,end=self._getOffsetsFromNVDAObject(position)
  File "displayModel.py", line 375, in _getOffsetsFromNVDAObject
    raise RuntimeError
RuntimeError

This is not a regression; it occurs when switching to flat review with 2013.1 as well.
Blocking #3517

@nvaccessAuto

Comment 2 by Michael Curran <mick@... on 2013-11-15 01:08
In [269c7be]:
```CommitTicketReference repository="" revision="269c7be616aac61619209424f5485694cab3d95a"
displayModel.DisplayModelTextInfo._getOffsetsFromNVDAObject: raise LookupError instead of RuntimeError when an object has no location. Allows switching to screen review when the navigator object has no screen location. Fixes #3454

Changes:
State: closed
@nvaccessAuto

Comment 3 by jteh on 2013-11-26 23:26
Changes:
Milestone changed from next to 2013.3

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015
@nvaccessAuto nvaccessAuto added this to the 2013.3 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment