New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a new alert appears it gets repeated twice #3481

Closed
nvaccessAuto opened this Issue Aug 30, 2013 · 5 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto

nvaccessAuto commented Aug 30, 2013

Reported by skypeben on 2013-08-30 09:46
I've created some sample code on jsfiddle. After 3 seconds a new alert will appear and it will be read out twice instead of the expected once.

http://jsfiddle.net/benhuggy/knmjj/

We're currently experiencing several instances of this inside our application.

Feel free to email me with any questions.

Ben Hughes
Software Development Engineer - Skype

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 20, 2013

Comment 1 by cottrell on 2013-09-20 18:15
It appears to be a problem when a div contains text directly. If the text is wrap using a

for example then the alert is only read once.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 16, 2014

Comment 2 by Michael Curran <mick@... on 2014-04-16 01:07
In [19fd268]:

Reverting a change from December 2009 commit 6c53a29d where IAccessible NVDAObject's name property was forced to contain content from IAccessibleText if there was no caret present.

This was supposed to allow focusable labels in Thunderbird to read nicer. However, this caused a long-standing issue where the content of alerts in web browsers would speak twice, and Thunderbird now seems to oddly expose a caret on the labels thus disabling the code change anyway.
Removing this code may possibly cause some other regressions as its very old. However, if regressions are found they should be handled specificly for each case, as clearly this code was too general.

Should be a fix re #3481. May affect re #2442, #2745

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 16, 2014

Comment 3 by Michael Curran <mick@... on 2014-04-16 01:11
In [54b3f8b]:

Merge branch 't3481' into next. Incubates #3481

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 30, 2014

Comment 4 by Michael Curran <mick@... on 2014-04-30 23:09
In [c64c98c]:

Merge branch 't3481'. Fixes #3481

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 30, 2014

Comment 5 by mdcurran on 2014-04-30 23:11
Changes:
Milestone changed from None to 2014.2

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015

@nvaccessAuto nvaccessAuto added this to the 2014.2 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment