New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

papenmeier driver: Handle non-existence of FTDI dll #3712

Closed
nvaccessAuto opened this Issue Dec 11, 2013 · 7 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Dec 11, 2013

Reported by jteh on 2013-12-11 21:37
On a system without the Papenmeier USB drivers installed (e.g. if a Papenmeier display was never connected), the FTDI dll won't exist. This causes ftdi2 to fail to import. The papenmeier driver should catch exceptions when importing ftdi2. It can then do one of two things if this failed:

  1. Return False from the check method so that the driver won't be used.
  2. Only disable USB so that Bluetooth still works. This is better because someone might pair a display via Bluetooth which they never connect via USB.

It'd be better if someone who owns a display can do this so that it can be tested properly.
Blocking #3819

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Dec 13, 2013

Comment 1 by halim on 2013-12-13 09:21
Yes, the driver should work with bluetooth connection only without installing usb drivers. I.ll post a patch soon.
Currently I don't have a Braillex Trio to test it.
Thx for reporting.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Dec 19, 2013

Attachment patch added by halim on 2013-12-19 06:14
Description:

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 31, 2014

Comment 3 by James Teh <jamie@... on 2014-01-31 04:37
In [a58c195]:

A Papenmeier braille display can now be used even if a Papenmeier display has never been connected via USB.

Re #3712.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 31, 2014

Comment 4 by James Teh <jamie@... on 2014-01-31 04:40
In [10a2a48]:

Merge branch 't3712' into next

Incubates #3712.

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 31, 2014

Comment 5 by jteh on 2014-01-31 04:40
Changes:
Milestone changed from None to next

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 14, 2014

Comment 6 by James Teh <jamie@... on 2014-02-14 06:03
In [a6fadcd]:

A Papenmeier braille display can now be used even if a Papenmeier display has never been connected via USB.

Fixes #3712.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 14, 2014

Comment 7 by jteh on 2014-02-14 06:05
Changes:
Milestone changed from next to 2014.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment