Reporting of spelling errors in Microsoft Word causes significant lag #3785

Closed
nvaccessAuto opened this Issue Jan 17, 2014 · 4 comments

1 participant

@nvaccessAuto

Reported by mdcurran on 2014-01-17 06:15
If moving the caret around a document in Microsoft Word with report spelling errors turned on (default), there is a noticable lag before the braille display is updated. Turning off reporting of spelling errors definitely reduces the lag.
When collecting text from MS Word, we currently check for a spelling error on every word, which would mean a great deal of calls.
Perhaps we should collect all spelling error offsets at the start and match them as we move through the text by word.

@nvaccessAuto

Comment 1 by Michael Curran <mick@... on 2014-01-17 06:24
In [df1fed5]:
```CommitTicketReference repository="" revision="df1fed5f1ea888f655ca1e0ff8e63d28b8e5aa13"
Merge branch 't3785' into next. Incubates #3785

Changes:
Added labels: incubating
@nvaccessAuto

Comment 2 by Michael Curran <mick@... on 2014-01-31 01:56
In [d642ae7]:
```CommitTicketReference repository="" revision="d642ae7f19c6d27eb08a88917048a0418d1b5192"
Merge branch 't3785'. Fixes #3785

Changes:
Removed labels: incubating
State: closed
@nvaccessAuto

Comment 3 by mdcurran on 2014-01-31 01:58
Changes:
Milestone changed from next to 2014.1

@nvaccessAuto

Comment 4 by Michael Curran <mick@... on 2014-02-02 10:56
In [7ac923a]:
```CommitTicketReference repository="" revision="7ac923a1182960174f33439b330bcb369abffe65"
Fix a possible buffer overrun which may have caused a crash in MS Word (picked up by MSVC RTC). Re #3785

VT_BOOL uses 16 bit values, so either VARIANT_BOOL or BOOL should be used. bool (c++) is only 8 bit which is not enough. The rest of calls with VT_BOOL were using BOOL 32 bit.

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015
@nvaccessAuto nvaccessAuto added this to the 2014.1 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment