Strings never freed when retrieving text from virtual buffers #591

Closed
nvaccessAuto opened this Issue Mar 8, 2010 · 1 comment

2 participants

@nvaccessAuto

Reported by jteh on 2010-03-08 16:37
Str:

  1. Open http://www.nvda-project.org/ in Firefox and move focus inside the buffer.
  2. Press NVDA+ctrl+z to activate the Python console.
  3. Type: ti = focus.virtualBuffer.makeTextInfo("all") for i in xrange(20000): t = ti.text Actual: Massive memory leak (NVDA shoots up to about 300 mb here). Expected: Uh... no memory leak. Note that closing the browser doesn't clean this up.

This happens because VBuf_getTextInRange allocates a string on the server side which is then marshalled to the client but never freed. We figured that ctypes was freeing the string when it was garbage collected by Python (which is actually incorrect, since ctypes didn't allocate it), but it seems that ctypes (correctly) doesn't do this after all.

@nvaccessAuto

Comment 1 by jteh on 2010-03-09 02:21
Fixed in 703bac8 with some cleanup in e226c48.
Changes:
State: closed

@nvaccessAuto nvaccessAuto added this to the 2010.1 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment