New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a column or row is marked as hidden, skip past it when table navigating. #6652

Closed
derekriemer opened this Issue Dec 19, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@derekriemer
Collaborator

derekriemer commented Dec 19, 2016

This URI demonstrates the issue.

data:text/html,<table><tr><th>class</th><th>credits</th><th aria-hidden="true">Hidden column for spacing</th><th>Grade</th></tr><tr aria-hidden="true"><td colspan=4>Fancy-image-spacing-icon goes-here</td></tr><tr><th>Fairy tales and their societal ramifications</th><td>3</td><td aria-hidden="true">I'm only used for spacing</td><td>B</td></tr><tr><th>HTML table hand-coding, and why it's painful</th><td>3</td><td aria-hidden="true"> Hidden column</td><td>A</td></tr></table>

Firefox:
NVDA reports the edge of the table if you try to move past row 1, and jumps out of the table at column 3. It jumps back in at col 4, but moving left jumps out at col 3, and you can't try to table navigate again.

Chrome:
Both column and row report "edge of table" when they should skip hidden columns.

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Feb 2, 2017

Collaborator

Any feedback or triage for this? I see this a fare amount when testing, and someone hides a column meant for visuals.

Collaborator

derekriemer commented Feb 2, 2017

Any feedback or triage for this? I see this a fare amount when testing, and someone hides a column meant for visuals.

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Feb 23, 2017

Collaborator

Hi:
I just wanted to make sure this wasn't lost in the need for triage?

Collaborator

derekriemer commented Feb 23, 2017

Hi:
I just wanted to make sure this wasn't lost in the need for triage?

@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Feb 24, 2017

Contributor

Not that it affects the bug, but I added colspan=4 to the "Fancy-image-spacing-icon goes-here" row.

I can reproduce this with Version: next-13899,af44c1d4
Seems like a bug that should be fixed.

Contributor

feerrenrut commented Feb 24, 2017

Not that it affects the bug, but I added colspan=4 to the "Fancy-image-spacing-icon goes-here" row.

I can reproduce this with Version: next-13899,af44c1d4
Seems like a bug that should be fixed.

@feerrenrut feerrenrut added bug p2 labels Feb 24, 2017

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Jun 28, 2017

Collaborator

should this be part of 2017webfix?

Collaborator

derekriemer commented Jun 28, 2017

should this be part of 2017webfix?

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Jun 29, 2017

Contributor

@derekriemer, how often do you see this in the wild?

The whole idea of hidden columns seems kinda broken to me. The space is still present; it still looks like a column visually. You can argue that the space is purely for layout, but this argument is flawed because it still affects the semantics. In this example, the column after the hidden column gets reported as column 4, not column 3. That's going to cause confusion for some users at least. I'm inclined to argue the author should at least use aria-colindex in this case. (NVDA doesn't support aria-colindex yet, but that's planned.)

That said, if this is occurring a lot in the wild, the chances of getting authors to fix things are probably limited and we'll need to work around this.

Contributor

jcsteh commented Jun 29, 2017

@derekriemer, how often do you see this in the wild?

The whole idea of hidden columns seems kinda broken to me. The space is still present; it still looks like a column visually. You can argue that the space is purely for layout, but this argument is flawed because it still affects the semantics. In this example, the column after the hidden column gets reported as column 4, not column 3. That's going to cause confusion for some users at least. I'm inclined to argue the author should at least use aria-colindex in this case. (NVDA doesn't support aria-colindex yet, but that's planned.)

That said, if this is occurring a lot in the wild, the chances of getting authors to fix things are probably limited and we'll need to work around this.

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Jul 1, 2017

Collaborator

@jcsteh I've seen this a few times in the wild, but usually it's things like We have an icon in this column that is useless to you and we'd like to hide the column from you, how can we do this. Most times, we put alt text on the icon, but sometimes, its just a useless pretty decoration, or even an real blank column for (Purely visual spacing), but hidden in table nav (And bureaucracy problems prevent me from saying hey, just do this correctly and put the icon in the same column or specify the column width to be twice as wide).

Also, skipping the column would be the correct behavior. Leaving the table or reporting we hit the edge is wrong, because the other stuff is still the same table, and shouldn't trap the user. It would be correct to say "Column 4" however.

Collaborator

derekriemer commented Jul 1, 2017

@jcsteh I've seen this a few times in the wild, but usually it's things like We have an icon in this column that is useless to you and we'd like to hide the column from you, how can we do this. Most times, we put alt text on the icon, but sometimes, its just a useless pretty decoration, or even an real blank column for (Purely visual spacing), but hidden in table nav (And bureaucracy problems prevent me from saying hey, just do this correctly and put the icon in the same column or specify the column width to be twice as wide).

Also, skipping the column would be the correct behavior. Leaving the table or reporting we hit the edge is wrong, because the other stuff is still the same table, and shouldn't trap the user. It would be correct to say "Column 4" however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment