Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document formatting preferences don't always apply to braille in browse mode #7615

Closed
dkager opened this issue Sep 20, 2017 · 3 comments
Closed

Comments

@dkager
Copy link
Collaborator

@dkager dkager commented Sep 20, 2017

Steps to reproduce:

  1. Select a braille table that can report italic text.
  2. From Preferences --> Document formatting, uncheck Font attributes.
  3. Read the following line (tested with Firefox 55).

This is italic text.

Expected behavior:

The italic text is not marked as italic.

Actual behavior:

Speech does indeed not mention the italic attribute, but braille still shows it.

Other information

Can't reproduce in Word, so it seems specific to browse mode.

First reported by @rimas-kudelis in #1885 (comment). The key take-away point is that this problem is quite annoying for users on the web, and if unresolved may lead to people "fixing" braille tables to exclude bold/italic/etc altogether.

@leonardder leonardder changed the title Document formatting preferences don't always apply to braille in borwse mode Document formatting preferences don't always apply to braille in browse mode Sep 20, 2017
@bramd
Copy link
Contributor

@bramd bramd commented Sep 23, 2017

@dkager For completeness and to be able to reproduce, which table would support such attributes?

@dkager
Copy link
Collaborator Author

@dkager dkager commented Sep 23, 2017

The Dutch tables, and probably UEB.

@dkager
Copy link
Collaborator Author

@dkager dkager commented Aug 19, 2018

This can be fixed with a simple patch of braille.py to consider formatConfig before sending text formatting flags to liblouis.

A further optimization is to not fetch IA2 text attributes and object attributes if all the formatConfig options that rely on them are disabled. This saves a few COM calls but the gains are probably minimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants