Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the following ctas(button) on the nvda website: 'Free Download' and 'Donate' are orange(bg) with white(fg) text. Would this fail color contrast compliant test? #8478

Closed
ronra opened this issue Jul 3, 2018 · 6 comments
Labels
p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority question

Comments

@ronra
Copy link

ronra commented Jul 3, 2018

Steps to reproduce:

Go to nvaccess site and you'll see the following cta(buttons): 'Donate' and 'Free Download' on the page.

Actual behavior:

Color contrast combination: orange background with white text would fail the tool (which would be webaim color contrast)

Expected behavior:

The question is regarding the site itself for nvda. Are ctas required to meet color contrast compliance in regards to WCAG 2.0?

System configuration:

N/A

NVDA Installed/portable/running from source:

N/A

NVDA version:

N/A

Windows version:

Windows 10

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

Other questions:

N/A

Does the issue still occur after restarting your PC?

N/A

Have you tried any other versions of NVDA?

N/A

@josephsl
Copy link
Collaborator

josephsl commented Jul 3, 2018 via email

@Brian1Gaff
Copy link

Brian1Gaff commented Jul 4, 2018 via email

@feerrenrut
Copy link
Contributor

I think this does fail the compliance test, and is something that NV Access would like to address. Thanks for pointing it out.

These colours match the branding and logo and so we are hesitant to change them. WCAG recommends using a halo to improve the contrast around the text in these buttons.

From the definition of "contrast ratio" in the glossary of WCAG2.1

NOTE
When there is a border around the letter, the border can add contrast and would be used in calculating the contrast between the letter and its background. A narrow border around the letter would be used as the letter. A wide border around the letter that fills in the inner details of the letters acts as a halo and would be considered background.

Some intereseting discussion on this approach when others have encountered this issue: GoogleChrome/accessibility-developer-tools#302
CodeforAustralia/school-finder#191

The current "Donate" button looks like this:
image

Using text-shadow: 0 0 0.001em black; to make the text look like the following:
image

The current banner text:
image

And with the shadow applied.
image

Further down the page are prices for featured products, these are orange on white:
image
And with the shadow applied.
image

@feerrenrut feerrenrut added the p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Aug 6, 2018
@feerrenrut
Copy link
Contributor

We should run these images by Emma for advice on whether applying the shadow is ok, and if she has any suggestions on how to address the styling of prices of featured products.

@feerrenrut
Copy link
Contributor

Quentin is going to have a play with the colours, and then Reef will update the website.

@feerrenrut
Copy link
Contributor

We have added text shadows to improve the contrast on these items, these will still fail many of the automated tools (which don't take the text shadow into account), however we believe that we have addressed the contrast requirements for these buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority question
Projects
None yet
Development

No branches or pull requests

5 participants