Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DBeaver AppModule #8905

Merged
merged 4 commits into from Nov 18, 2018
Merged

Conversation

JosielSantos
Copy link
Contributor

@JosielSantos JosielSantos commented Nov 1, 2018

This is a fix to DBeaver, an accessible database
tool that lets us explore graphically almost all types of databases (MySQL, SQL server, PostgreSQL, ...).

It is based on Eclipse SDK, so it has same problems that Zend Studio and Eclipse for Java.
Basically I copied the file source/appModules/zendstudio.py to source/appModules/dbeaver.py.

Changelog entry

New features

@ehollig
Copy link
Collaborator

ehollig commented Nov 2, 2018

Does this PR fix #8426

Copy link
Collaborator

@LeonarddeR LeonarddeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a copyright header as in eclipse.py? The proper copyright would be:
#Copyright (C) 2018 NV Access Limited, Josiel Santos

@JosielSantos
Copy link
Contributor Author

Thanks for approving!
I added and committed the copyright message.

@LeonarddeR
Copy link
Collaborator

Great!

@michaelDCurran michaelDCurran merged commit c5c0c95 into nvaccess:master Nov 18, 2018
@nvaccessAuto nvaccessAuto added this to the 2018.4 milestone Nov 18, 2018
@Adriani90
Copy link
Collaborator

@JosielSantos there is issue #8426 regarding this software. Could you have a look at it? It seems there are still some problems with the grids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants