Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA skips button text at the end of the line #9388

Closed
tspivey opened this issue Mar 19, 2019 · 5 comments
Closed

NVDA skips button text at the end of the line #9388

tspivey opened this issue Mar 19, 2019 · 5 comments
Milestone

Comments

@tspivey
Copy link
Contributor

@tspivey tspivey commented Mar 19, 2019

Steps to reproduce:

  1. Load this into firefox:
data:text/html,<p>This is a test with text and buttons in a testing paragraph. This is a test. <button>Button label 1 with text</button></p>
  1. Move to the beginning of the document and press f.

Actual behavior:

NVDA says Button label 1 with button

Expected behavior:

NVDA should say Button label 1 with text button

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

Version: alpha-16885,2ed7dbae

Windows version:

Windows 10 Version 1809 (OS Build 17763.316)

Name and version of other software in use when reproducing the issue:

Firefox 65.0.2, Chrome Version 73.0.3683.75 (Official Build) (64-bit)

Other information about your system:

Other questions

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

No

@DrSooom
Copy link

@DrSooom DrSooom commented Mar 20, 2019

@tspivey: Please update Firefox to 66.0 and try again. This issue could be a regression.

Loading

@tspivey
Copy link
Contributor Author

@tspivey tspivey commented Mar 20, 2019

Upgrading Firefox didn't fix it.

Loading

@DataTriny
Copy link
Contributor

@DataTriny DataTriny commented Mar 23, 2019

Hi all,

I looked at this issue and know exactly what's happening, but don't have an idea on how to fix it efficiently.

Using the provided HTML snippet, I found that if you press the B key, NVDA will report the entire button content. But, the paragraph that contains it is long enough so that NVDA will split it in two lines. However, when setting up the quick navigation gesture for formField, we have readUnit=textInfos.UNIT_LINE, meaning that we will only report the first line of the TextInfo (obviously to avoid reporting a lengthy textbox content).

What we would need in the case of formField is to set this readUnit value based on the role of the queried control. Looking at the code in speech.speakTextInfo(), the way to retrieve this role seems slow, so I don't know if it's a good idea to use it inside the TextInfoQuickNavItem.report() for instance.

Any ideas?

Loading

@DrSooom
Copy link

@DrSooom DrSooom commented Mar 23, 2019

In other words: If you increase the value in the option "Maximum Number of Characters on One Line" from "100" (default) to "120" in the Browse Mode NVDA Settings, this issue doesn't occur. Therefore I wasn't able to reproduce it because this value is always set to "120" on my systems. (I know that this is just a workaround.)

Loading

@DataTriny
Copy link
Contributor

@DataTriny DataTriny commented Mar 23, 2019

Exactly! But forget about my last message as I found a cheap way to check the role of an NVDAObject from a TextInfoQuickNavItem. Fixed by #9401.

Loading

@nvaccessAuto nvaccessAuto added this to the 2019.1 milestone Mar 28, 2019
@michaelDCurran michaelDCurran removed this from the 2019.1 milestone Mar 31, 2019
@michaelDCurran michaelDCurran added this to the 2019.2 milestone Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants