Differentiate preselected from just selected text #9909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of selection messages for preselected and just selected text neesd to be different. When a control with preselected text gains focus, we must inform them it is selected first so they do not unintentionally modify the text. When a user intentionally selects text, the 'selected' part of the message is still important (for users who may not be familiar with a command), but the text selected is more important. This commit differentiates and documents the differences here with helper methods to make these announcements.
|
@lukaszgo1 You may be interested in reviewing this PR, it further modifies work you did previously to provide different message for preselected text and text just selected by the user. |
feerrenrut
added a commit
that referenced
this pull request
Jul 11, 2019
feerrenrut
deleted the
differentiatePreselectedTextFromJustSelectedText
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #9028
Link to issue number:
None
Summary of the issue:
The order of selection messages for preselected and just selected text needs to be different. When a control with preselected text gains focus, we must inform them it is selected first so they do not unintentionally modify the text. When a user intentionally selects text, the 'selected' part of the message is still important (for users who may not be familiar with a command), but the text selected is more important.
Description of how this pull request fixes the issue:
This commit differentiates and documents the differences here with helper methods to make these announcements.
Testing performed:
Selected text, confirmed that the message was "text selected"
Used run dialog to land on preselected text, confirmed the message was "selected text"
Known issues with pull request:
None
Change log entry:
None