Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing the cd-cs feature #1167

Merged
merged 4 commits into from
Mar 22, 2021
Merged

Introducing the cd-cs feature #1167

merged 4 commits into from
Mar 22, 2021

Conversation

s1ddly
Copy link
Contributor

@s1ddly s1ddly commented Feb 14, 2021

I found in my usage that due to the proximity of the 's' and 'd' key, I would commonly type cs when I mean to say cd.
I am hoping to address that with this update to the rules.

@s1ddly
Copy link
Contributor Author

s1ddly commented Mar 8, 2021

@scorphus have you had a chance to look at this yet?

@s1ddly
Copy link
Contributor Author

s1ddly commented Mar 19, 2021

FB_IMG_1616075794372

@BimboPolitics
Copy link

Following this github is the best decision ive made all week

Copy link
Collaborator

@scorphus scorphus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @s1ddly 👋 🤣

Sorry for the delay! I was wondering if we could fix this some other way — that being the outcome of a hackthon I mentored a couple weeks ago. But it looks like that will need a bit more working.

Thank you for your contribution!

thefuck/rules/cd_cs.py Outdated Show resolved Hide resolved
s1ddly and others added 2 commits March 21, 2021 19:40
Thanks Scorphus!

Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
This character(–) has lead to the commit failing some of the tests. 
I am removing it from the code and we should see the tests pass now.
@s1ddly
Copy link
Contributor Author

s1ddly commented Mar 21, 2021

Hey Mate,

I found that some of the python 2.7 build test cases failed on this one.
It seems that it doesn't like the up and down arrows in the comment.
Are we good to proceed with the failed tests or should I remove the offending characters?

Thanks, Sid.

thefuck/rules/cd_cs.py Show resolved Hide resolved
Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
@s1ddly
Copy link
Contributor Author

s1ddly commented Mar 22, 2021

Looks like that fixed it.
Thats a pretty useful trick, I'll be sure to remember that for my future projects :)

@scorphus scorphus merged commit 4c7479b into nvbn:master Mar 22, 2021
@scorphus
Copy link
Collaborator

Thanks, @s1ddly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants