-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing the cd-cs feature #1167
Conversation
@scorphus have you had a chance to look at this yet? |
Following this github is the best decision ive made all week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @s1ddly 👋 🤣
Sorry for the delay! I was wondering if we could fix this some other way — that being the outcome of a hackthon I mentored a couple weeks ago. But it looks like that will need a bit more working.
Thank you for your contribution!
Thanks Scorphus! Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
This character(–) has lead to the commit failing some of the tests. I am removing it from the code and we should see the tests pass now.
Hey Mate, I found that some of the python 2.7 build test cases failed on this one. Thanks, Sid. |
Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
Looks like that fixed it. |
Thanks, @s1ddly! |
I found in my usage that due to the proximity of the 's' and 'd' key, I would commonly type cs when I mean to say cd.
I am hoping to address that with this update to the rules.