Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Windows CMD and easier setup for Powershell #1329

Merged
merged 7 commits into from Jul 10, 2023

Conversation

gerardog
Copy link
Contributor

@gerardog gerardog commented Sep 7, 2022

Windows CMD support is almost impossible without removing c:\Python310\Scripts\fuck.exe, so I did (only affects windows installation), and added a fuck.bat (mandatory for CMD support).

This created a problem for first time users of PowerShell / pwsh, so I created fuck.ps1 to solve it, and also auto configure the $PROFILE

Related

@gerardog
Copy link
Contributor Author

gerardog commented Sep 8, 2022

Some proof of how I tested it:

On pwsh:
image
image

On cmd
image

@gerardog
Copy link
Contributor Author

gerardog commented Mar 10, 2023

No one interested in making it work on Windows?

@scorphus
Copy link
Collaborator

Hola, Gerardo!

No one interested in making in work on Windows?

Yes, definitely. Great to see some developments in that direction. I'll review this PR asap.

Thanks for contributing!

Copy link
Collaborator

@scorphus scorphus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider my comments and suggestions below.

scripts/fuck.bat Outdated Show resolved Hide resolved
scripts/fuck.ps1 Outdated Show resolved Hide resolved
scripts/fuck.ps1 Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@gerardog gerardog requested a review from scorphus July 9, 2023 02:39
Copy link
Collaborator

@scorphus scorphus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @gerardog! Apologies for the delay.

@scorphus scorphus merged commit 3cd187a into nvbn:master Jul 10, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants