Suggest ag -Q when relevant

[josephfrazier]

This detects when ag suggests the -Q option, and adds it.

[coveralls]

Coverage increased (+0.03%) to 93.121% when pulling db4b379 on josephfrazier:ag-literal into db7dffd on nvbn:master.

[coveralls]

Coverage increased (+0.03%) to 93.121% when pulling b090596 on josephfrazier:ag-literal into db7dffd on nvbn:master.

[coveralls]

Coverage increased (+0.03%) to 93.147% when pulling d2e0a19 on josephfrazier:ag-literal into ce6b82c on nvbn:master.

[scorphus]

Nice additions. I've gathered some comments.

Thanks!

[scorphus]

Please, add a new line here. [E302 expected 2 blank lines, found 1]

[scorphus]

Please remove this unused import. [F401 imported but unused]

[scorphus]

I'd recommend refactoring the test as the following:

import pytest
from thefuck.rules.ag_literal import get_new_command, match
from tests.utils import Command


@pytest.fixture
def stderr():
    return ('ERR: Bad regex! pcre_compile() failed at position 1: missing )\n'
            'If you meant to search for a literal string, run ag with -Q\n')


@pytest.mark.parametrize('script', ['ag \('])
def test_match(script, stderr):
    assert match(Command(script=script, stderr=stderr))


@pytest.mark.parametrize('script', ['ag foo'])
def test_not_match(script):
    assert not match(Command(script=script))


@pytest.mark.parametrize('script, new_cmd', [
    ('ag \(', 'ag -Q \(')])
def test_get_new_command(script, new_cmd, stderr):
    assert get_new_command((Command(script=script, stderr=stderr))) == new_cmd

[scorphus]

Isn't endswith() a slightly better option than in?

[coveralls]

Coverage increased (+0.03%) to 93.145% when pulling a964af7 on josephfrazier:ag-literal into ce6b82c on nvbn:master.

[josephfrazier]

Thanks for the review, @scorphus! I've made some changes addressing your comments.

[scorphus]

You nailed it, @josephfrazier! 👍

Thanks!

[nvbn]

Thanks!