Improve source generation performance #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
force-pushed
the
dev/jela/sourgen-update
branch
2 times, most recently
from
2c76aab
to
be1ba03
Compare
- Avoid using strings for types comparisons in IsImplementingInterface and IsCollectionOrListType - Simplify FindEventType, add more lookups caching for type members - Add more caching for FindType
jeromelaban
force-pushed
the
dev/jela/sourgen-update
branch
from
be1ba03
to
f991e0f
Compare
dr1rrb
approved these changes
Jan 8, 2019
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.Reflection.cs
Show resolved
Hide resolved
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlRedirection/XamlMember.cs
Outdated
Show resolved
Hide resolved
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlRedirection/XamlType.cs
Outdated
Show resolved
Hide resolved
carldebilly
approved these changes
Jan 8, 2019
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlRedirection/XamlType.cs
Outdated
Show resolved
Hide resolved
Improves generation speed.
jeromelaban
force-pushed
the
dev/jela/sourgen-update
branch
from
f991e0f
to
a359fc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Xaml Source generation is performing faster, as more type resolutions are cached and less strings are used to interact with the Roslyn API. The update of the source generation tasks package also improves the incremental build performance using the new host server on windows.
PR Checklist
Please check if your PR fulfills the following requirements:
Internal Issue (If applicable):
https://nventive.visualstudio.com/DefaultCollection/Umbrella/_workitems/edit/143604