Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support passing metadata #53

Merged
merged 5 commits into from
Aug 23, 2023
Merged

feat: support passing metadata #53

merged 5 commits into from
Aug 23, 2023

Conversation

virajkarandikar
Copy link
Contributor

No description provided.

@virajkarandikar virajkarandikar mentioned this pull request Aug 7, 2023
Closed
@rmittal-github
Copy link
Contributor

Looks good

rmittal-github
rmittal-github previously approved these changes Aug 8, 2023
View reviewed changes
@virajkarandikar
Copy link
Contributor Author

This needs to be updated for use grpc call credentials.

@virajkarandikar virajkarandikar changed the title feat: support passing metadata draft: feat: support passing metadata Aug 9, 2023
@virajkarandikar virajkarandikar changed the title draft: feat: support passing metadata feat: support passing metadata Aug 23, 2023
@rmittal-github
Copy link
Contributor

need to pass metadata param from scripts/asr/riva_streaming_asr.client.py also

@virajkarandikar
Copy link
Contributor Author

need to pass metadata param from scripts/asr/riva_streaming_asr.client.py also

Fixed

@rmittal-github rmittal-github changed the base branch from main to release/2.13.0 August 23, 2023 10:23
@virajkarandikar virajkarandikar merged commit b367963 into nvidia-riva:release/2.13.0 Aug 23, 2023
rmittal-github added a commit that referenced this pull request Sep 12, 2023
@rmittal-github @virajkarandikar
feat: support passing metadata (#53) (#56)
4f003cc 
* feat: support passing metadata

* pass credentials via metadata call credentials

* Update common proto submodule

Co-authored-by: Viraj Karandikar <16838694+virajkarandikar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmittal-github rmittal-github rmittal-github approved these changes

@junkin junkin Awaiting requested review from junkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@virajkarandikar @rmittal-github