Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian install procedure has you changing the entire distribution to unstable to install Neovim #859

Closed
EvanCarroll opened this issue Apr 18, 2024 · 6 comments

Comments

@EvanCarroll
Copy link
Contributor

EvanCarroll commented Apr 18, 2024

Currently the documentation for Debian instructs you to do this,

sudo apt update
sudo apt install make gcc ripgrep unzip git
echo "deb https://deb.debian.org/debian unstable main" | sudo tee -a /etc/apt/sources.list
sudo apt update
sudo apt install -t unstable neovim

The problem is this line,

echo "deb https://deb.debian.org/debian unstable main" | sudo tee -a /etc/apt/sources.list

That effectively moves you to the unstable version of debian. If you run apt-get dist-upgrade and download all of your packages, and then you run the above code and you rerun apt-get dist-upgrade you will be on the unstable version of Debian.

This is probably not what you want.

The problem that you're trying to solve is that Debian stable (right now "bookworm") ships Neovim 0.7.2. Unfortunately, there is no newer version of Neovim in the repository, nor in the backports repository (because of a shortage of manpower). However, upgrading your entire distribution to unstable is a very poor suggestion that can cause all kinds of problems and pain, including total failure.

At the very least, the user should be informed

@EvanCarroll
Copy link
Contributor Author

This edit was done last month by @dam9000 a222805

A better way for the Linux's is probably just to use upstream neovim's prebundled binary if that works for you, https://github.com/neovim/neovim/blob/master/INSTALL.md#pre-built-archives-2

@EvanCarroll EvanCarroll changed the title Debian install instruction downright dangerous -- install Neovim by switching to unstable? Debian install procedure has you changing the distribution to unstable to install Neovim Apr 18, 2024
@EvanCarroll EvanCarroll changed the title Debian install procedure has you changing the distribution to unstable to install Neovim Debian install procedure has you changing the entire distribution to unstable to install Neovim Apr 18, 2024
@feoh
Copy link
Collaborator

feoh commented Apr 18, 2024

@EvanCarroll I see what you mean.

As an interim step, would you or anyone commenting here please consider updating the verbiage in the install instructions to warn appropriately?

A problem I see is that in order to update Debian to the point where you can build Neovim, you kind of have to go unstable.

Perhaps simply stating that up front and offering the pre-built binary as an alternative is the way to go here? I'll leave it to the Debian folks to craft an appropriate and best practice conformant set of install instructions.

@EvanCarroll
Copy link
Contributor Author

EvanCarroll commented Apr 18, 2024

A problem I see is that in order to update Debian to the point where you can build Neovim, you kind of have to go unstable.

I don't believe this is true. I don't know why specifically you couldn't build Neovim 0.9 on Debian stable (bookworm).

Debian folks to craft an appropriate and best practice

I would use either the binaries from neovim, or flatpak. Or we could beg the Debian neovim/vim maintainer to onboard me, and I'll personally start rolling out backports for stable. But I don't think he'd be down.

Can we just yank the Debian instructions pending the discussion. I think changing the distribution is a bit too sledgehammery to be useful. I can't see that making anyone happy.

@feoh
Copy link
Collaborator

feoh commented Apr 18, 2024

No one is asking you to take over Maintainersship of a package. All I'm suggesting is that since you were kind enough to point out problems with our documentation as it currently stands and since most of us do not run Debian, perhaps you would consider crafting alternative text that does not violate best practices.

EvanCarroll added a commit to EvanCarroll/kickstart.nvim that referenced this issue Apr 18, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
@dam9000
Copy link
Contributor

dam9000 commented Apr 18, 2024

@EvanCarroll I'm sorry about the confusion I caused with this. I'm not a regular debian user so I was going from various guides on the net and was under impression that the unstable repo will be used only if the -t unstable parameter was provided, perhaps that is not the true so indeed this needs to be corrected.

@feoh
Copy link
Collaborator

feoh commented Apr 18, 2024

@dam9000 Please don't apologize. You've been working super hard here and trying to support everyone on myriad platforms, whether or not you use them regularly yourself.

Great that we've got folks who "live" there actually helping us craft something better!

feoh pushed a commit that referenced this issue Apr 20, 2024
Attempted fix for #859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
dam9000 added a commit to dam9000/kickstart-modular.nvim that referenced this issue Apr 20, 2024
@feoh feoh closed this as completed in 9f5176f Apr 20, 2024
appuchias pushed a commit to appuchias/kickstart.nvim that referenced this issue Apr 21, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
appuchias pushed a commit to appuchias/kickstart.nvim that referenced this issue Apr 21, 2024
appuchias pushed a commit to appuchias/kickstart.nvim that referenced this issue Apr 21, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
appuchias pushed a commit to appuchias/kickstart.nvim that referenced this issue Apr 21, 2024
MeVsTheVoices pushed a commit to MeVsTheVoices/kickstart.nvim that referenced this issue Apr 23, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
MeVsTheVoices pushed a commit to MeVsTheVoices/kickstart.nvim that referenced this issue Apr 23, 2024
rodolfolabiapari pushed a commit to rodolfolabiapari/kickstart.nvim that referenced this issue Apr 27, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
rodolfolabiapari pushed a commit to rodolfolabiapari/kickstart.nvim that referenced this issue Apr 27, 2024
orhosko pushed a commit to orhosko/kickstart.nvim that referenced this issue Apr 28, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
orhosko pushed a commit to orhosko/kickstart.nvim that referenced this issue Apr 28, 2024
cannahum pushed a commit to cannahum/kickstart.nvim that referenced this issue Apr 28, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
cannahum pushed a commit to cannahum/kickstart.nvim that referenced this issue Apr 28, 2024
William-Wolke pushed a commit to William-Wolke/kickstart.nvim that referenced this issue May 3, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
William-Wolke pushed a commit to William-Wolke/kickstart.nvim that referenced this issue May 3, 2024
gcaufield added a commit to gcaufield/kickstart.nvim that referenced this issue May 16, 2024
* upstream/master: (46 commits)
  Automatically set detached state as needed. (nvim-lua#925)
  fix: debug.lua (nvim-lua#918)
  Add diff to treesitter's ensure_installed languages (nvim-lua#908)
  Move LspDetach handler near kickstart-lsp-highlight group (nvim-lua#900)
  README: add clipboard tool dependency (nvim-lua#886)
  Update README.md (nvim-lua#875)
  fix: highlight group clear on each attach (nvim-lua#874)
  Fix highlight errors when lsp crash or stop (nvim-lua#864)
  Fix deprecation notice of inlay hints (nvim-lua#873)
  Add a commented out example of the classic complete keymaps. Fixes nvim-lua#866 (nvim-lua#868)
  Minor improvements of debian install instructions. Fixes nvim-lua#859 (nvim-lua#869)
  Update README.md (nvim-lua#860)
  fix: restore Mason config timing for DAP startup (again) (nvim-lua#865)
  Add gitsigns recommended keymaps as an optional plugin (nvim-lua#858)
  Move plugin examples from README to optional plugin files (nvim-lua#831)
  Enable inlay hints for the supporting servers (nvim-lua#843)
  Fix: nvim-lua#847 - add prefer_git to treesitter config (nvim-lua#856)
  Comment about nerd font selection. Fixes nvim-lua#853 (nvim-lua#854)
  Arch, btw (nvim-lua#852)
  Update README (nvim-lua#832)
  Add a pull request template (nvim-lua#825)
  README: move backup and paths from external deps to install section (nvim-lua#819)
  Don't lazy load conform plugin (nvim-lua#818)
  Add a keymap space-f to format buffer using conform (nvim-lua#817)
  Add instructions to quit :lazy. Fixes nvim-lua#761
  fix nvim-lua#799 (nvim-lua#800)
  README: wrap long lines (nvim-lua#784)
  Update README.md (nvim-lua#781)
  Add nvim-nio as dependency for nvim-dap-ui (nvim-lua#774)
  Some suggestions and capitalised a few words (nvim-lua#771)
  ...

 > **NOTE**
dmaspataud pushed a commit to dmaspataud/kickstart.nvim that referenced this issue May 18, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
dmaspataud pushed a commit to dmaspataud/kickstart.nvim that referenced this issue May 18, 2024
EdwinStep pushed a commit to EdwinStep/nvim that referenced this issue May 20, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
darren-omori pushed a commit to darren-omori/kickstart.nvim that referenced this issue May 24, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
darren-omori pushed a commit to darren-omori/kickstart.nvim that referenced this issue May 24, 2024
eunmann pushed a commit to eunmann/kickstart.nvim that referenced this issue Jun 19, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
eunmann pushed a commit to eunmann/kickstart.nvim that referenced this issue Jun 19, 2024
johnlonganecker pushed a commit to johnlonganecker/kickstart.nvim that referenced this issue Jun 25, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
johnlonganecker pushed a commit to johnlonganecker/kickstart.nvim that referenced this issue Jun 25, 2024
halyD pushed a commit to halyD/kickstart.nvim that referenced this issue Jul 8, 2024
Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.
halyD pushed a commit to halyD/kickstart.nvim that referenced this issue Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants