Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: highlight group clear on each attach #874

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix: highlight group clear on each attach #874

merged 1 commit into from
Apr 22, 2024

Conversation

sudo-tee
Copy link
Contributor

In my other pull request when opening a 2 buffers it would clear the whole group and removing the commands for other buffers.

It was an oversight on my part. and I introduced an unwanted side effect.

dam9000
dam9000 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@dam9000 dam9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@feoh feoh merged commit 942b261 into nvim-lua:master Apr 22, 2024
1 check passed
MeVsTheVoices pushed a commit to MeVsTheVoices/kickstart.nvim that referenced this pull request Apr 23, 2024
@sudo-tee
fix: highlight group clear on each attach (nvim-lua#874)
5fb82ec
real-mielofon pushed a commit to real-mielofon/kickstart.nvim that referenced this pull request Apr 26, 2024
@sudo-tee @real-mielofon
fix: highlight group clear on each attach (nvim-lua#874)
a339200
rodolfolabiapari pushed a commit to rodolfolabiapari/kickstart.nvim that referenced this pull request Apr 27, 2024
@sudo-tee @rodolfolabiapari
fix: highlight group clear on each attach (nvim-lua#874)
2d65cc3
orhosko pushed a commit to orhosko/kickstart.nvim that referenced this pull request Apr 28, 2024
@sudo-tee @orhosko
fix: highlight group clear on each attach (nvim-lua#874)
962cc00
cannahum pushed a commit to cannahum/kickstart.nvim that referenced this pull request Apr 28, 2024
@sudo-tee @cannahum
fix: highlight group clear on each attach (nvim-lua#874)
f18d0a1
William-Wolke pushed a commit to William-Wolke/kickstart.nvim that referenced this pull request May 3, 2024
@sudo-tee @William-Wolke
fix: highlight group clear on each attach (nvim-lua#874)
88218e7
gcaufield added a commit to gcaufield/kickstart.nvim that referenced this pull request May 16, 2024
@gcaufield
Merge 'upstream/master' into master
cca4273 
* upstream/master: (46 commits)
  Automatically set detached state as needed. (nvim-lua#925)
  fix: debug.lua (nvim-lua#918)
  Add diff to treesitter's ensure_installed languages (nvim-lua#908)
  Move LspDetach handler near kickstart-lsp-highlight group (nvim-lua#900)
  README: add clipboard tool dependency (nvim-lua#886)
  Update README.md (nvim-lua#875)
  fix: highlight group clear on each attach (nvim-lua#874)
  Fix highlight errors when lsp crash or stop (nvim-lua#864)
  Fix deprecation notice of inlay hints (nvim-lua#873)
  Add a commented out example of the classic complete keymaps. Fixes nvim-lua#866 (nvim-lua#868)
  Minor improvements of debian install instructions. Fixes nvim-lua#859 (nvim-lua#869)
  Update README.md (nvim-lua#860)
  fix: restore Mason config timing for DAP startup (again) (nvim-lua#865)
  Add gitsigns recommended keymaps as an optional plugin (nvim-lua#858)
  Move plugin examples from README to optional plugin files (nvim-lua#831)
  Enable inlay hints for the supporting servers (nvim-lua#843)
  Fix: nvim-lua#847 - add prefer_git to treesitter config (nvim-lua#856)
  Comment about nerd font selection. Fixes nvim-lua#853 (nvim-lua#854)
  Arch, btw (nvim-lua#852)
  Update README (nvim-lua#832)
  Add a pull request template (nvim-lua#825)
  README: move backup and paths from external deps to install section (nvim-lua#819)
  Don't lazy load conform plugin (nvim-lua#818)
  Add a keymap space-f to format buffer using conform (nvim-lua#817)
  Add instructions to quit :lazy. Fixes nvim-lua#761
  fix nvim-lua#799 (nvim-lua#800)
  README: wrap long lines (nvim-lua#784)
  Update README.md (nvim-lua#781)
  Add nvim-nio as dependency for nvim-dap-ui (nvim-lua#774)
  Some suggestions and capitalised a few words (nvim-lua#771)
  ...

 > **NOTE**
li6in9muyou pushed a commit to li6in9muyou/nvim--dotfiles that referenced this pull request May 17, 2024
@sudo-tee @li6in9muyou
fix: highlight group clear on each attach (nvim-lua#874)
cf364a1
dmaspataud pushed a commit to dmaspataud/kickstart.nvim that referenced this pull request May 18, 2024
@sudo-tee @dmaspataud
fix: highlight group clear on each attach (nvim-lua#874)
e86000b
EdwinStep pushed a commit to EdwinStep/nvim that referenced this pull request May 20, 2024
@sudo-tee @EdwinStep
fix: highlight group clear on each attach (nvim-lua#874)
f0d3abe
dvessel pushed a commit to dvessel/kickstart.nvim that referenced this pull request May 21, 2024
@sudo-tee @dvessel
fix: highlight group clear on each attach (nvim-lua#874)
e00507f
darren-omori pushed a commit to darren-omori/kickstart.nvim that referenced this pull request May 24, 2024
@sudo-tee @darren-omori
fix: highlight group clear on each attach (nvim-lua#874)
f565b20
eunmann pushed a commit to eunmann/kickstart.nvim that referenced this pull request Jun 19, 2024
@sudo-tee @eunmann
fix: highlight group clear on each attach (nvim-lua#874)
b55d807
johnlonganecker pushed a commit to johnlonganecker/kickstart.nvim that referenced this pull request Jun 25, 2024
@sudo-tee
fix: highlight group clear on each attach (nvim-lua#874)
f6b5737
halyD pushed a commit to halyD/kickstart.nvim that referenced this pull request Jul 8, 2024
@sudo-tee @halyD
fix: highlight group clear on each attach (nvim-lua#874)
2ce2085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dam9000 dam9000 dam9000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sudo-tee @dam9000 @feoh