Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: add a Nerd Font requirement #703

Closed
wants to merge 1 commit into from

Conversation

dam9000
Copy link
Contributor

@dam9000 dam9000 commented Mar 5, 2024

Fixes #700
A Nerd Font is required by:

  • mini.statusline
  • Lazy plugin manager
  • Neo-tree.nvim - not enabled by default however instructions on how to add it are in the README

Fixes nvim-lua#700
A Nerd Font is required by:
- mini.statusline
- Lazy plugin manager
- Neo-tree.nvim - not enabled by default however
    instructions on how to add it are in the README
@tjdevries
Copy link
Member

Hmm, I think it might be better to try and disable the nerdfonts by default for mini and lazy. Do you by any chance happen to know how to do that? Otherwise I will look.

@dam9000
Copy link
Contributor Author

dam9000 commented Mar 5, 2024

I think I do, I can open a PR for that, although to be honest I like the look of nerd font icons better.

@dam9000
Copy link
Contributor Author

dam9000 commented Mar 5, 2024

Here: #711

@feoh
Copy link
Collaborator

feoh commented Mar 5, 2024

I really love the look of nerd font, icons too! Why are we getting rid of that again?

I guess asking people to download and install fonts is an extra step. Let's just make them easy to turn back on again for those of us who love them and have them installed by default as the first thing we do when we come to a new system :-)

@dam9000
Copy link
Contributor Author

dam9000 commented Mar 6, 2024

@feoh that's an excellent suggestion, so I made a new PR which makes the nerd font an optional requirement and allows you to enable it with a simple global flag, please consider merging this instead:
#716

@dam9000
Copy link
Contributor Author

dam9000 commented Mar 6, 2024

Closing this since a better alternative was merged.

@dam9000 dam9000 closed this Mar 6, 2024
@dam9000 dam9000 deleted the pr-nerdfonts branch March 6, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange glyph icons appear.
3 participants