Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Nerd Font requirements for lazy.nvim and mini.statusline #711

Closed
wants to merge 1 commit into from

Conversation

dam9000
Copy link
Contributor

@dam9000 dam9000 commented Mar 5, 2024

Fixes #700

This has two changes:

  • lazy.nvim: use unicode instead of Nerd Font icons.
  • mini.statusline: disable icons for git branch, lsp, filetype (filetype icons are only enabled if nvim-web-devicons is also loaded)

For reference, the unicode icons are copied from the suggestion from:
https://github.com/folke/lazy.nvim/blob/aedcd79811d491b60d0a6577a9c1701063c2a609/README.md?plain=1#L473

If you don't want to use a Nerd Font, you can replace the icons with Unicode symbols.

Fixes nvim-lua#700

This has two changes:
- lazy.nvim: use unicode instead of Nerd Font icons.
- mini.statusline: disable icons for git branch, lsp, filetype
  (filetype icons are only enabled if nvim-web-devicons is also loaded)
@dam9000
Copy link
Contributor Author

dam9000 commented Mar 5, 2024

For reference, here is how it looks like on a ubuntu 22.04 without nerd fonts and with this change:

mini-statusline-no-icons

lazy-unicode

I personally prefer the look of Nerd Font icons, but you decide.

@joram56
Copy link

joram56 commented Mar 6, 2024

Went through the recent youtube tutorial, and I felt like nerd fonts does not really fit in with the general level of basic configurations the rest of the project does. It feels like a very user specific configuration.

@dam9000
Copy link
Contributor Author

dam9000 commented Mar 6, 2024

As suggested by @feoh, I made a new PR which makes the nerd font an optional requirement and allows you to enable it with a simple global flag, please consider merging this instead:
#716

@dam9000
Copy link
Contributor Author

dam9000 commented Mar 6, 2024

Closing this since a better alternative was merged.

@dam9000 dam9000 closed this Mar 6, 2024
@dam9000 dam9000 deleted the pr-no-nerdfonts branch March 6, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange glyph icons appear.
2 participants