-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prioritize user config for theme-loader on windows (#1213) #1214
Conversation
44f4c4c
to
2660fc4
Compare
@shadmansaleh Man I even referenced the commit in my issue and didn't notice lualine_require just duplicates the same logic... Should I patch that one too? I've never used the custom require function so I idk in what circumstances it will have the same problem. Edit2: lualine.nvim/lua/lualine_require.lua Lines 65 to 67 in b5e8bb6
Edit:
lualine.nvim/lua/lualine_require.lua Lines 56 to 73 in b5e8bb6
|
Fixes the second part of: nvim-lualine#1213 The same logic fixed in (nvim-lualine#1214) is duplicated in the lualine_require module, which appears to be used internally for loading things like extensions. On windows, user defined extensions that overwrite the builtin similarly cannot be loaded due to the same string matching issue. In addition, the number of queried runtime files is always less-than or equal to 1 due to the `all` parameter for `nvim_get_runtime_file` being set to false. Making it impossible to sort the list of files and prioritize ones within the users config path `vim.fn.stdpath("config")`.
Fixes the second part of: #1213 The same logic fixed in (#1214) is duplicated in the lualine_require module, which appears to be used internally for loading things like extensions. On windows, user defined extensions that overwrite the builtin similarly cannot be loaded due to the same string matching issue. In addition, the number of queried runtime files is always less-than or equal to 1 due to the `all` parameter for `nvim_get_runtime_file` being set to false. Making it impossible to sort the list of files and prioritize ones within the users config path `vim.fn.stdpath("config")`.
No description provided.