Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide human-readable output format for file level test results. #39

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Provide human-readable output format for file level test results. #39

merged 4 commits into from
Mar 28, 2023

Conversation

sergii4
Copy link
Collaborator

@sergii4 sergii4 commented Mar 27, 2023

No description provided.

@sergii4 sergii4 changed the title Provide human-readable output format for file level test results. Fix #32 Provide human-readable output format for file level test results. Mar 27, 2023
@sergii4
Copy link
Collaborator Author

sergii4 commented Mar 27, 2023 •
edited
Loading

Fix #32. There were no processed test results on the file level, so neotest provided raw go test -json output

akinsho
akinsho reviewed Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a drive by comment but I never got round to setting up a stylua.toml to enforce spacing for this project. I think it'd be a good idea to setup so PRs don't end up causing big changes in formatting 🤷🏾‍♂️

@sergii4
Copy link
Collaborator Author

sergii4 commented Mar 27, 2023

@akinsho , agree, working on it

@sergii4
Copy link
Collaborator Author

sergii4 commented Mar 27, 2023 •
edited
Loading

@akinsho returned formatting to previous standard

akinsho
akinsho approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 👍🏾 (not tested or anything though 😅)

@sergii4 sergii4 merged commit 8acc8fa into main Mar 28, 2023
@sergii4 sergii4 deleted the fix/test-output-format branch March 29, 2023 12:35
@tfrs1 tfrs1 mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinsho akinsho akinsho approved these changes

Assignees

@akinsho akinsho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergii4 @akinsho @rcarriga