Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Makefile is having problems with creating *.dll #87

Merged
merged 3 commits into from
Dec 2, 2022
Merged

fix: Makefile is having problems with creating *.dll #87

merged 3 commits into from
Dec 2, 2022

Conversation

dev4s
Copy link
Contributor

@dev4s dev4s commented Nov 27, 2022

The switches/parameters for commands needs to be escaped, without it - it shows errors, or doesn't compile properly

fix #82

Makefile Outdated Show resolved Hide resolved
@Conni2461
Copy link
Member

CI failure is unrelated, please ignore.

dev4s and others added 3 commits December 2, 2022 11:52
The switches/parameters for commands needs to be escaped, without it - it shows errors :)
@Conni2461 Conni2461 merged commit ae9d95d into nvim-telescope:main Dec 2, 2022
@Conni2461
Copy link
Member

Thanks for the fix :)

@Conni2461
Copy link
Member

This introduced new issues see #88 and #90.

And you check if your issue is still fixed with #89? Thanks

@dev4s
Copy link
Contributor Author

dev4s commented Dec 12, 2022

I will check that :)

@@ -1,8 +1,8 @@
CFLAGS = -Wall -Werror -fpic -std=gnu99

ifeq ($(OS),Windows_NT)
MKD = cmd /C mkdir

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Conni2461 this seems to cause issues on windows, no idea why it was changed, but the old version worked just fine i think. With that commit make fails to build

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like i said here: #87 (comment) i am aware of this issue.

But i can't test anything because i am not on a windows machine. This PR fixed fix #82

And my last question was, does #89 fix, #82 and the new issues #88, #90 ?

I needed someone to confirm this, but tbh no one did so i'am just gonna merge

@Conni2461 Conni2461 mentioned this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] make enters interactive cmd.exe on Windows with MSYS2
3 participants